How to properly stop a TCPServer? about evpp HOT 7 CLOSED

Thank you for using evpp.
Please paste the sample code that can produce the your problem.

And we suggest that you can read the unit test code testTCPServerSilenceShutdown at here https://github.com/Qihoo360/evpp/blob/master/test/tcp_server_test.cc#L72-L82. This tests the TCPServer to stop silently.

from evpp.

Any updates?

from evpp.

I was trying to stop the server when SIGINT or SIGTERM were recieved with the next function.

evpp::EventLoop* loop;
evpp::TCPServer* server_ptr;
static void s_signal_handler(int signal_value) {
   loop->Stop(); //using only this: error on server destructor
   server_ptr->Stop(); //using only this: program hangs
}

Finally I arrived to a solution by calling Stop in both loop and server in that order.
In the test unit the Reset method is called in both loop and server to stop, what is the difference between Stop and Reset? I guess Reset makes possible to reuse the objects, is only that?

from evpp.

We should stop TCPServer and after then, we can stop EventLoop, and lastly we call Reset to release the memory of the objects.

Please try the following code. See https://github.com/Qihoo360/evpp/blob/master/test/tcp_server_test.cc#L87-L97

    std::unique_ptr<evpp::EventLoop> loop(new evpp::EventLoop);
    std::unique_ptr<evpp::TCPServer> tsrv(new evpp::TCPServer(loop.get(), addr, "tcp_server", 2));
    bool rc = tsrv->Init();
    rc = tsrv->Start();
    loop->RunAfter(evpp::Duration(1.0), [&tsrv, &loop]() { tsrv->Stop(); loop->Stop(); });
    loop->Run();
    loop.reset();
    tsrv.reset();

from evpp.

So Stop has to be called inside the loop with a RunAfter necessarily?

from evpp.

No, that's not necessary. You can read more examples.

1. We can stop the EventLoop in it's own thread immediately : https://github.com/Qihoo360/evpp/blob/master/benchmark/post_task/post_task2.cc#L60
2. We also can stop the EventLoop in another thread : https://github.com/Qihoo360/evpp/blob/master/benchmark/post_task/post_task6.cc#L59

from evpp.

Thank you for the help.

from evpp.