Git Product home page Git Product logo

Comments (15)

nyalldawson avatar nyalldawson commented on September 17, 2024 2

Yeah - I think it should be a "fix it if you're refactoring an area" thing

from qgis-enhancement-proposals.

NathanW2 avatar NathanW2 commented on September 17, 2024

+1 I don't see any downsides to this at all.

Link seems to be dead though.

from qgis-enhancement-proposals.

sbrunner avatar sbrunner commented on September 17, 2024

You insist that will affect only the new signals, why don't migrate all the current old style signal and slot?

from qgis-enhancement-proposals.

nyalldawson avatar nyalldawson commented on September 17, 2024

You mean in one go? Two reasons:

  1. It's a horrible tedious job

from qgis-enhancement-proposals.

sbrunner avatar sbrunner commented on September 17, 2024

OK, then the goal is to migrate them progressively :-) right?

from qgis-enhancement-proposals.

nyalldawson avatar nyalldawson commented on September 17, 2024
  1. There's big potential to introduce new bugs if not careful. Eg there's traps with handling overloaded slots. I'd rather play it safe and upgrade them on demand.

from qgis-enhancement-proposals.

nyalldawson avatar nyalldawson commented on September 17, 2024

Bah... I can't type at the moment ;)

from qgis-enhancement-proposals.

mhugo avatar mhugo commented on September 17, 2024

+1 for this proposal, everything that can be caught at compilation time is a win

from qgis-enhancement-proposals.

vpicavet avatar vpicavet commented on September 17, 2024

Could you specify if it affects the Python API too or not ?

from qgis-enhancement-proposals.

nyalldawson avatar nyalldawson commented on September 17, 2024

This direct impact python code. That can (and should already) be using newer style connections:

http://nathanw.net/2015/04/24/psa-use-new-style-qt-signals-and-slots-not-the-old-style

from qgis-enhancement-proposals.

nyalldawson avatar nyalldawson commented on September 17, 2024

That should be "doesn't impact". Autocorrect on phone my seems to get worse every day....

from qgis-enhancement-proposals.

luipir avatar luipir commented on September 17, 2024

+1 from my side

from qgis-enhancement-proposals.

m-kuhn avatar m-kuhn commented on September 17, 2024

+1

from qgis-enhancement-proposals.

NathanW2 avatar NathanW2 commented on September 17, 2024

I have approved this due to the number of votes and how there is no downsides.

from qgis-enhancement-proposals.

NathanW2 avatar NathanW2 commented on September 17, 2024

@nyalldawson Just added the example from the Qt docs into QEP just for quick reference.

from qgis-enhancement-proposals.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.