Move from astyle to clang-format for C++ code formatting about qgis-enhancement-proposals HOT 6 OPEN

For reference, for QField clang-format is used with the following options which offer a (IMHO) acceptable compatibility. It's been a while, so maybe nowadays even better things are possible: https://github.com/opengisch/QField/blob/master/.clang-format with https://github.com/opengisch/QField/blob/master/.pre-commit-config.yaml#L43-L47

from qgis-enhancement-proposals.

A big +1 from me.

We've made some tries in the past and I believe we can get close to no-modification of our source files.

The main issue we had was the indent of access modifiers (see https://bugs.llvm.org/show_bug.cgi?id=19056 and https://reviews.llvm.org/D60225) which was finally solved in 2021 (see https://reviews.llvm.org/rG2a42c759ae7bb09dd448d188138f310d014fcab6).
This would mean LLVM 12+ and this is probably acceptable now!

Another point regarding modification of headers is … sipify… As you probably don't want to dig into this, that's a good motivation to stick to our current format :) (just the format, not the tool!)

And that would mean one tool to rule all the branches, otherwise, we'll probably live with astyle with the current branches until they are not maintained anymore and clang-format for the new ones, but that's not a big deal.

from qgis-enhancement-proposals.

+1 to use a simple pre-commit for this kind of task :-)

from qgis-enhancement-proposals.

Precommit looks good, from a few projets using it.

And that would mean one tool to rule all the branches, otherwise, we'll probably live with astyle with the current branches until they are not maintained anymore and clang-format for the new ones, but that's not a big deal.

The backport bot will mainly fail if the formatting is different between active branches so it will require a lof manual backport.

from qgis-enhancement-proposals.

Precommit looks good, from a few projets using it.

And that would mean one tool to rule all the branches, otherwise, we'll probably live with astyle with the current branches until they are not maintained anymore and clang-format for the new ones, but that's not a big deal.

The backport bot will mainly fail if the formatting is different between active branches so it will require a lof manual backport.

Right, I guess we will need to reformat all the "active" branches.

from qgis-enhancement-proposals.

A big +1 from me too. I use it on various projects and it's excellent (especially since it's been stabilized since versions ~ >= 12).

fyi, I've discovered a tool - Clang Format Detector that "promises" to convert file styles to .clang-format. I don't have a truly satisfactory result yet, but it's pretty close.

from qgis-enhancement-proposals.