Git Product home page Git Product logo

Comments (7)

qdouble avatar qdouble commented on July 20, 2024

@Zigzag95 I may remove some, but not sure about all (especially not the extra polyfills script as that would make certain browsers download more stuff unnecessarily)... and then it could also increase the amount browsers need to download for common files that would already be cached, like google fonts and icons.

In the meantime, if you don't want any online dependencies, you could just put those files in the assets folder and reference that in index.html...or install as npm dependency.

from angular-webpack-starter.

aminebizid avatar aminebizid commented on July 20, 2024

No worry about extra downloads since webpack is doing a tree shaking.
I'll make a PR anyway.

from angular-webpack-starter.

qdouble avatar qdouble commented on July 20, 2024

@Zigzag95 most of those files are already minified and some shouldn't necessarily be packaged together... but if you make a pr, we can probably push it towards a strictly offline-friendly branch

from angular-webpack-starter.

DzmitryShylovich avatar DzmitryShylovich commented on July 20, 2024

a strictly offline-friendly branch

do u really want to support one more branch? :)

from angular-webpack-starter.

qdouble avatar qdouble commented on July 20, 2024

@DzmitryShylovich if it's a strict clone of this one minus the index.html files, it shouldn't be difficult to maintain... I'm conflicted on whether or not this current branch should have no CDN use, what's your opinion on this?

from angular-webpack-starter.

DzmitryShylovich avatar DzmitryShylovich commented on July 20, 2024

I would say it's overkill to have additional branch for such (trivial) use case. It's pretty easy and straightforward how to make this starter work in no Internet environment.

from angular-webpack-starter.

qdouble avatar qdouble commented on July 20, 2024

@DzmitryShylovich yeah, I mean if someone wants to PR for it, I could see doing it..

as far as this main branch, I think getting hammer.js from npm may be a good thing... but I don't see a strong reason for most people to have a need to load google fonts and icons on their own server... and automatically loading extra safari/ie/edge polyfills isn't advantageous for Chrome/Firefox users, so CDN wins there too. As the main branches, I can only see a strong argument for hammerjs.

Now if we start transitioning towards the starter being for progressive apps, then all offline would make more sense as far as the main branches.

from angular-webpack-starter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.