Comments (10)
@alvipeo well directly using scss instead of scss will make AOT compile fail, which on the Other branches you will see I'm css for the styles URL but working with scss that is being converted with node-sass...(this issue will change once we can use the ngtools/webpack plugin). Beyond that, I suppose using JQuery at all may make it problematic to use Universal...not quite sure about AOT.
I'm not going to make a Bootstrap 3/Jquery branch as I think it's generally recommended to avoid using JQuery as you're probably going to run into a ton of issue when it comes to Universal, Web Workers and possibly AOT. I was working on a boostrap 4 branch that uses ng2-bootstrap, but they currently have an issue with AOT (which should be solved eventually).
from angular-webpack-starter.
Well, some people do not need Universal, that's why I used minimal branch.
I'd go for a Bootstrap 4, but it seems like its alpha state is never ending story, so I'll skip. ng2-bootstrap looks good, I'm going to try it.
Didn't get what you said about scss... at all ;)
from angular-webpack-starter.
@alvipeo well of course, some people won't need to use Universal or Web Workers and maybe won't use AOT, but as using JQuery can be very problematic and limiting, I rather not create a branch based around using it.
As far as scss, the ngc compiler does not support or understand sass...so using it in your styles url will cause AOT compilation to fail. In the other branches, you'll see that I mitigate this by compiling the scss using node-sass and referencing the css that is output in the stylesUrl array. There is going to be a webpack plugin for AOT that will get around this, but it's not available for public use yet.
from angular-webpack-starter.
ok, thanks. I'd pass Bootstrap, but what are options? Bootstrap 4 is not even close to ready, Material is not going to be even at beta by the end of the year... so how would one make a web ui really? This I think is the main reason people use React.
from angular-webpack-starter.
@alvipeo If you're just using Bootstrap 4 for it's css, I wouldn't worry about it as the api for that is pretty stable. Combine that with ng2-bootstrap which should become AOT compatible soon, and you're golden.
from angular-webpack-starter.
ng-bootstrap*
and it's already aot ready
from angular-webpack-starter.
@DzmitryShylovich yeah, ng-bootstrap is the correct repo 😄
so this issue should be closed now? ng-bootstrap/ng-bootstrap#796
from angular-webpack-starter.
Hmm I thought it work in aot. My bad.
from angular-webpack-starter.
@DzmitryShylovich yeah, it still doesn't appear to work just yet, it's not exporting all of the .ngfactory files that it needs to
I just added the bootstrap branch I was working on locally... whenever they fix AOT on ng-bootstrap, I'll add the fix there
https://github.com/qdouble/angular2webpack2-starter/tree/bootstrap
from angular-webpack-starter.
wow! Thank you guys for the Bootstrap 4 branch!
from angular-webpack-starter.
Related Issues (20)
- file is not exists
- Error in universal:AOT build: Cannot find module './ngfactory/app/server.app.module.ngfactory'. HOT 3
- How to add fonts HOT 3
- Can you rename the repository? HOT 2
- warnings when running `yarn` HOT 1
- AOT and platform-browser-dynamic HOT 1
- Is there a simple example that mimics communication between sibling components? HOT 1
- Is this project still active ? HOT 1
- Http(Client)Module has changed
- Typescript source maps HOT 2
- Webpack 4 / Angular 6 HOT 7
- yarn test failing HOT 2
- Ability to skip bundle analysis for CI prod builds HOT 1
- Getting "Cannot find module 'zone.js/dist/zone-node'" when deploying on production server HOT 6
- Can't run tests, at-loader can't find .ts files! HOT 1
- Getting error running Universal out of the box HOT 3
- Can you please add comments to your code. HOT 1
- How to see karma output in debug window? HOT 6
- Issue with npm/Yarn Install HOT 2
- Angular 7 HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from angular-webpack-starter.