Comments (2)
For 1)
IIRC yes there was, because we assume that the done is at the root and that the root batch-size is indicative of the env structure.
What would it mean to have a nested "init"
?
Happy to see a refactoring if it is well defined.
For 2) I don't know, if the value isn't used anywhere we can remove it
from rl.
The transform seems to be ok with multiple reset and init keys (the only thing it needs to do is just match an init key for any reset key)
It is just the init method that needs some refreshing I think.
from rl.
Related Issues (20)
- [Discussion] Remember TorchRL: the state of memory in TorchRL HOT 15
- [BUG] Issues with `TensorDictPrimer` HOT 9
- [BUG] Surprising `MLP` default behavior HOT 2
- [BUG] Collector `set_truncated` overwrites environement done
- [BUG] `TensorDictPrimer` overwrites nested specs in the environemnt
- [BUG] SAC Loss reshapes tensordict causing loss of time dimension
- [BUG] CUDA out-of-memory issue when creating a custom game environment with MultiaSyncDataCollector HOT 4
- [Feature Request] Inverse of `VecNorm` Transform HOT 1
- [Feature Request] `break_when_all_done` in `env.rollout()`
- [Feature Request] Partial steps in env
- [Feature Request] MCTS Issue tracker
- [BUG] Clarify non-opitionality of `TensordictPrimer`
- [BUG] Documentation of BinaryDiscreteTensorSpec can be confusing HOT 2
- [Feature Request] Make GymLikeEnv compatible with IsaacLab Envs HOT 1
- [Feature Request] `EarlyStopping` for `torchrl.trainers.Trainer`
- [Feature Request] Metadata for specs HOT 2
- [BUG] Calculation of GAE fails with recurrent critic HOT 1
- [BUG] dumps() failing on ReplayBuffer with LazyMemmapStorage HOT 1
- [Feature Request] Extend TDLambdaEstimator with QLambdaEstimator
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rl.