Git Product home page Git Product logo

Comments (3)

apaszke avatar apaszke commented on April 27, 2024

I actually don't think it's a good idea. All optimization we do makes sense only for scalar valued functions, and implicit initialization of a scalar "grad output" to 1 is sensible in this case, because it gives us correct gradient values. We also allow starting backward from an arbitrary location in the graph, as long as you provide gradient w.r.t. each element of the tensor, because it's also perfectly valid mathematically, but I'm not sure why should we interpret "backward from a tensor" as "backward from a sum for tensor elements".

@rbgirshick when do you think it would be useful?

from pytorch.

rbgirshick avatar rbgirshick commented on April 27, 2024

It's really not important. In the past I've occasionally debugged gradient computations given a known incoming gradient. Choosing all ones is usually a good choice for debugging since it's easy to understand. So this change would only save one line and an extra arg in a niche use case. Feel free to close without implementing.

from pytorch.

soumith avatar soumith commented on April 27, 2024

ok, closing this, as it'll be a niche use case, and adding a torch.ones(x.size()) wont be that bad and be more explicit.

from pytorch.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.