Git Product home page Git Product logo

Comments (4)

eellison avatar eellison commented on July 21, 2024 2

If we run with either TORCHINDUCTOR_COORDINATE_DESCENT_TUNING or force persistent reductions to occur it beats eager. Funny enough the coordinate descent tuning it discovers is essentially a persistent reduction because it makes the rblock equal to the length of the loop:

:XBLOCK: 1, RBLOCK: 8192, num_warps: 16, num_ctas: 1, num_stages: 1

If we force the rblock to be equal to the length of the loop is there any difference between persistent reduction and normal codegen 🤔 assuming that triton can dedup loads.

I can look into improving the heuristics for this case.

from pytorch.

shunting314 avatar shunting314 commented on July 21, 2024 1

If rnumel is even larger, we would not be able to use persistent reduction.

I think this online softmax PR (#127011 ) would help here.

from pytorch.

Chillee avatar Chillee commented on July 21, 2024 1

I think this is pretty similar to some of the experiments I did previously on softmax perf - block size tuning is the main gap here.

from pytorch.

jansel avatar jansel commented on July 21, 2024

Interesting, perhaps some more evidence of suboptimal heuristics. cc @AlnisM @Chillee

from pytorch.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.