Give`wait_tensor()` a schema that reflects its side effect about pytorch HOT 4 OPEN

What are the chances effect tokens would help here?

from pytorch.

Just curious, is there such a notion today of a schema that marks a side effect? What would that look like?

from pytorch.

should this just be wait_tensor(Tensor(a!) self) -> Tensor(a!)?

from pytorch.

There are a couple of options for option 2 "update the schema of this op to mark it as mutating its input (to reflect the side effect)":

a) wait_tensor(Tensor(a!) self) -> Tensor(a!). This requires us to add a functional version of the op and reinplacing logic to inductor for it.
b) wait_tensor(Tensor(a!) self) -> (). This one doesn't require us to add a functional op (we will automatically generate a functional op
c) we've been adding new "print" operators that have arbitrary side effects that automatically get functionalized (@angelayi @yanboliang). There's a side table where we actually mark the operators as having side effects.

from pytorch.