Git Product home page Git Product logo

Comments (3)

flishwang avatar flishwang commented on September 27, 2024

Paramters generally should not be directly changed in the forward pass. For best practise, you may use self.register_buffer instead.

Anyway, if you really want to change the data in a parameter, use the following code:

def forward(self, x: torch.Tensor) -> torch.Tensor:
        n_tokens = x.size(1)
        with torch.no_grad():
            self.cache.data = torch.roll(self.cache, -n_tokens, dims=1)
        self.cache[:, -n_tokens:, :] = x
        return self.cache

By the way, I'm not sure what you want to do with MyModule(torch.zeros(2, 3, 4))(torch.zeros(2, 2, 4)). Generally the returned tensor/parameter cannot be called.

from pytorch.

mikaylagawarecki avatar mikaylagawarecki commented on September 27, 2024

This seems to be the expected behavior, you would expect an out of place op on a Parameter (e.g. torch.roll) to return a tensor, and you attempt to reassign this to self.cache, which fails with the expected error message

from pytorch.

thomassajot avatar thomassajot commented on September 27, 2024

Thank you for your reply. As you mentioned, register_buffer might be the correct way to go.
The goal of the cache is to append historical elements alongside the current tensor.

from pytorch.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.