Comments (8)
cc @jgong5
from pytorch.
The failure seems to come from special casing of bool at
pytorch/torch/_inductor/codegen/cpp.py
Lines 2077 to 2085 in 91bf952
Tried fixing this in #126406, but that's not the correct solution.
from pytorch.
Is there a CI job with PYTORCH_ALL_SAMPLES=1
that runs periodically or is that too costly?
Running
PYTORCH_ALL_SAMPLES=1 python test/inductor/test_torchinductor_opinfo.py -k test_comprehensive_constant_pad_nd_cpu_bool -vv
gives us a test case that fails.
from pytorch.
or is that too costly?
I think it's too broken. Trying to enable all samples testing on as many operators as possible could be a worthwhile project though.
from pytorch.
Will take a look for this failure.
from pytorch.
A similar failure can be seen with
PYTORCH_ALL_SAMPLES=1 python test/inductor/test_torchinductor_opinfo.py -k test_comprehensive__chunk_cat_cpu_bool
It fails with
Output:
/tmp/tmp7vma6sgm/xo/cxojdq4ofjj257z6cmt43wndg43l3kt7mx2kvr6mwuq6haam22qj.cpp: In function 'void kernel(const bool*, const bool*, const bool*, bool*, bool*, bool*)':
/tmp/tmp7vma6sgm/xo/cxojdq4ofjj257z6cmt43wndg43l3kt7mx2kvr6mwuq6haam22qj.cpp:86:34: error: operands to '?:' have different types 'at::vec::CPU_CAPABILITY::VecMask<float, 1>' and 'at::vec::CPU_CAPABILITY::Vectorized<bool>'
86 | auto tmp6 = tmp3 ? tmp4() : at::vec::Vectorized<bool>(static_cast<bool>(false));
| ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
from pytorch.
A similar failure can be seen with
PYTORCH_ALL_SAMPLES=1 python test/inductor/test_torchinductor_opinfo.py -k test_comprehensive__chunk_cat_cpu_boolIt fails with
Output: /tmp/tmp7vma6sgm/xo/cxojdq4ofjj257z6cmt43wndg43l3kt7mx2kvr6mwuq6haam22qj.cpp: In function 'void kernel(const bool*, const bool*, const bool*, bool*, bool*, bool*)': /tmp/tmp7vma6sgm/xo/cxojdq4ofjj257z6cmt43wndg43l3kt7mx2kvr6mwuq6haam22qj.cpp:86:34: error: operands to '?:' have different types 'at::vec::CPU_CAPABILITY::VecMask<float, 1>' and 'at::vec::CPU_CAPABILITY::Vectorized<bool>' 86 | auto tmp6 = tmp3 ? tmp4() : at::vec::Vectorized<bool>(static_cast<bool>(false)); | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Thanks for reporting it. Will also fix it in the same PR.
from pytorch.
Thanks @leslie-fang-intel for the PR. Opened another issue at #126824
from pytorch.
Related Issues (20)
- [Export] Mutating module attribute error during export on YOLOX HOT 2
- torch._export.aot_compile reports an error when compiling the model after int8 quantization HOT 12
- [Break XPU] Inductor UT test_torchinductor.py::test_uint_xpu regression Introduced by PR #129686
- torch.compile fails for complex nested_tensor code HOT 6
- models `.forward` and exported onnx are not the same
- Convert Co-DETR to ONNX Format HOT 2
- `unbind_copy` gives unexpected results on 1-dimensional inputs, or 0-dimensional outputs HOT 2
- [Break XPU] The newly added test_ctr_not_moved_to_cuda_when_used_in_index_put failed on XPU due to device-bias code
- AttributeError: DistributedDataParallel with torch.compile using nn.Linear.forward method HOT 4
- Where does torch check for autocast op availability? HOT 1
- [pre-grad][batch_relu] batch_relu pass is triggered with inline_inbuilt_nn_modules causing major regression HOT 9
- torch.fx.Tracer.record_stack_traces is broken in torch 2.4.0 HOT 2
- CMake cannot detect non-default fp16 installation path HOT 1
- `size()` type for `size` argument of `rand()/randn()/randint()` works against the doc HOT 1
- Cannot load torchscript model on windows HOT 4
- BertForSequenceClassification.from_pretrained broken when using FSDP HOT 2
- `size()` type for `size` argument of `randn()` works against the doc HOT 1
- cpp wrapper doesn't work with cudagraphs HOT 3
- `size()` type for `size` argument of `randint()` works against the doc HOT 1
- `size()` type for `size` argument of `normal()` works against the doc HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pytorch.