Git Product home page Git Product logo

Comments (4)

guangyey avatar guangyey commented on May 25, 2024 2

Thanks for the request. That sounds fair to me but we should really implement this in a way that is making the code more generic, not adding more if-statements along.

btw @guangyey should we add you to the cc list for module: xpu in #24422 to make sure you get cc-ed on these issues? Or should I add someone else in cc there?

Thanks, @albanD could you help add @gujinghui @EikanWang @fengyuan14, and @guangyey to cc list for module: xpu.

from pytorch.

dvrogozh avatar dvrogozh commented on May 25, 2024

I've tried to implement this feature - see PR #125530.

from pytorch.

albanD avatar albanD commented on May 25, 2024

Thanks for the request.
That sounds fair to me but we should really implement this in a way that is making the code more generic, not adding more if-statements along.

btw @guangyey should we add you to the cc list for module: xpu in #24422 to make sure you get cc-ed on these issues? Or should I add someone else in cc there?

from pytorch.

dvrogozh avatar dvrogozh commented on May 25, 2024

That sounds fair to me but we should really implement this in a way that is making the code more generic, not adding more if-statements along.

I will gladly make changes to the PR #125530 I've posted if there is a consensus between maintainers on the direction. Please, start reviewing the PR and add notes on what you would like to see changed.

from pytorch.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.