Git Product home page Git Product logo

Comments (4)

malfet avatar malfet commented on June 4, 2024

@zou3519 can you run collect env (or at the very least say whether or not you run it on Mac or Linux)

And results are bound to be different if you are using different python version that the one used in CI. Luckily one can run the same container

And last but not least, one should run lintrunner --all, as -a stands for --apply-patches if I'm not mistaken

from pytorch.

zou3519 avatar zou3519 commented on June 4, 2024

collect_env output: https://gist.github.com/zou3519/5b7b877c77810574e67084299291c03e

lintrunner failed in mypy (https://github.com/pytorch/pytorch/actions/runs/8571927570/job/23494053626). I have the same version of mypy locally that lintrunner is using. The difference is that lintrunner in CI is on python 3.9 but I'm on Python 3.11.

So... maybe a mypy thing with different versions of Python

from pytorch.

zou3519 avatar zou3519 commented on June 4, 2024

I'm seeing this again on some more PRs. The interesting thing is running mypy directly does catch issues, but running lintrunner --all-files does not

from pytorch.

zou3519 avatar zou3519 commented on June 4, 2024

I think my problem may have been that when the dmypy daemon hangs, lintrunner erroneously reports mypy as passing. Action item would be to get lintrunner to error out in this situation.

from pytorch.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.