Git Product home page Git Product logo

Comments (7)

gvanrossum avatar gvanrossum commented on May 24, 2024

Yes, the allowed forms for base classes and the idioms to use for various
cases are not yet sorted out. I also don't like that mypy has both
Generic[T] and AbstractGeneric[T].

On Wed, Jan 14, 2015 at 11:09 PM, Jukka Lehtosalo [email protected]
wrote:

The PEP should probably mention what happens if a generic class is used as
a base class.

Examples to consider:

class StrList(List[str]): ... # StrList is not generic

T = TypeVar('T')

class MyList(List[T]): ... # Mypy requires Generic[T] as a base class, but it's ugly

x = Undefined(MyList[int])


Reply to this email directly or view it on GitHub
#41.

--Guido van Rossum (python.org/~guido)

from typing.

vlasovskikh avatar vlasovskikh commented on May 24, 2024

See also https://github.com/JukkaL/typing/issues/36 about Generic and AbstractGeneric.

from typing.

JukkaL avatar JukkaL commented on May 24, 2024

Currently this is not valid (due to Python semantics):

class A(metaclass=ABCMeta): pass
class B(Generic[T], A): pass   # metaclass conflict

This is okay, however:

class A(metaclass=ABCMeta): pass
class B(AbstractGeneric[T], A): pass   # good

Maybe we should just replace Generic with AbstractGeneric and remove AbstractGeneric? This way most reasonable inheritance patterns should work okay. With the current mypy approach, inheritance hierarchies are inherently fragile -- if some base class adds ABCMeta as metaclass (due to adding an abstract base class, for example), it can break subclasses that are generic.

from typing.

gvanrossum avatar gvanrossum commented on May 24, 2024

So, what shall we do? If at all possible I'd like to only have Generic.

from typing.

JukkaL avatar JukkaL commented on May 24, 2024

I updated mypy and typing to only have Generic, which also supports defining ABCs. It seems to be okay to me, but I need to do more testing.

from typing.

JukkaL avatar JukkaL commented on May 24, 2024

Added section 'Arbitrary generic types as base classes' to the PEP. Not closing this issue this yet until somebody has reviewed it.

from typing.

vlasovskikh avatar vlasovskikh commented on May 24, 2024

Everything looks good to me, except for #85.

from typing.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.