fix for an AIX optimizer weirdness in getargs.c about cpython HOT 4 CLOSED

from cpython.

Vladimir, can you comment on this?

from cpython.

Never mind! :-)

from cpython.

Moved here from [email protected]

This patch fixes a problem on AIX with the signed int case code in getargs.c, after Trent Mick's intervention about MIN/MAX overflow checks. The AIX compiler/optimizer generates bogus code with the default flags "-g -O" causing test_builtin to fail: int("10", 16) <> 16L. Hopefully, swapping the two checks in the signed int code makes the problem go away.

Also, make the error messages fit in 80 char lines in the source.

[Trent Mick]:

Does it?

[me]
Yes, it does. Without optimization, everything was okay, with -O it crashed. This is the second time that swapping statemets in the code alleviates bugs in some (old) AIX optimizers ... [snip] So, as far as
such patches don't hurt the semantics of the code, they are fine.

[Trent]

Seconded. +1

from cpython.