Git Product home page Git Product logo

Comments (9)

tmick avatar tmick commented on June 1, 2024

from cpython.

freddrake avatar freddrake commented on June 1, 2024

Looks good to me, and properly skips the large file test on my Linux box. A second iteration may be useful to provide separate options for different resources (cpu/disk/ram), but it's not clearly needed at this time.

Accepted as-is.

from cpython.

gvanrossum avatar gvanrossum commented on June 1, 2024

This was accepted ages agon -- what are you waiting for?

from cpython.

tim-one avatar tim-one commented on June 1, 2024

Fred, can you test this on a Linux with > 2Gb files (needs the --have-resources switch; read Trent's comment), or pass it on to someone who can? I can't do more than stare at this, and nothing in my staring hit my eye. Well, Guido may hate the long option name (--have-resources), especially given that even with all those letters <wink>, it's not really self-describing.

from cpython.

tim-one avatar tim-one commented on June 1, 2024

Fred, do something with this or assign it to some other Unix geek?

from cpython.

tmick avatar tmick commented on June 1, 2024

I confirm that, to the best of my knowledge and belief, this
contribution is free of any claims of third parties under
copyright, patent or other rights or interests ("claims"). To
the extent that I have any such claims, I hereby grant to CNRI a
nonexclusive, irrevocable, royalty-free, worldwide license to
reproduce, distribute, perform and/or display publicly, prepare
derivative versions, and otherwise use this contribution as part
of the Python software and its related documentation, or any
derivative versions thereof, at no cost to CNRI or its licensed
users, and to authorize others to do so.

I acknowledge that CNRI may, at its sole discretion, decide
whether or not to incorporate this contribution in the Python
software and its related documentation. I further grant CNRI
permission to use my name and other identifying information
provided to CNRI by me for use in connection with the Python
software and its related documentation.

from cpython.

tmick avatar tmick commented on June 1, 2024

This patch adds a test for largefiles (creating, seeking, telling, etc.).
The test skips if there is no largefile support.

There is one further problem. The test basically involves creating a file
greater than 2GB and playing with it. On UN*X systems with sparse files this
is no problem. On Win64 (which I have heard *can* do sparse files, but not in
Python yet), however, >2GB space and a *long* time is required to run the
test. I don't think it is reasonable to turn this on by default... so here is
what I did.

I extended regrtest.py to accept the --have-resources switch. This sets
test_support.use_large_resources, which is checked in test_largefile.py.
By default 'use_large_resources' is false. On Win64, then, by default the
largefile test is skipped but can be run via the --have-resources switch to
regrtest.py or by running the test directly. This seems to me the Right
Thing.

The affected files are:
Lib/test/regrtest.py
Lib/test/test_support.py
Lib/test/test_largefile.py (new)
Lib/test/output/test_largefile (new)

from cpython.

tmick avatar tmick commented on June 1, 2024

--have-at-least-2GB-on-hard-drive-and-am-going-for-coffee-<wink>

from cpython.

tmick avatar tmick commented on June 1, 2024

Sorry about the delay.
Had to make some small changes to get the old patch to apply.

from cpython.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.