job.refresh() doesn't exist but is needed (hacky fix included) about python-gitlab HOT 4 OPEN

@1ace they're different objects because they're created from different endpoints, and don't necessarily have the same amount of details returned (or even the same attribute structure, as we've found out recently with merge request reviewer details returned from different endpoints). So it could be a bit confusing changing the object attributes dynamically like that. And the GitLab API is too inconsistent for us to assume they could be considered the same type of object IMO.

We sort of follow the REST API path segment structure for the most part with this approach. We also document this a bit:

This is far from the only case, so if we wanted to be consistent here, we would have to add this path hack to almost every endpoint where similar-but-not-quite-the-same resources are returned. This is why for now we simply document how to get an editable resource when fetched from a different endpoint:

https://python-gitlab.readthedocs.io/en/stable/faq.html#i-cannot-edit-the-merge-request-issue-i-ve-just-retrieved

However, if refresh() is needed for ProjectJob we should be able to add that. But technically there is no single GET call for /pipelines/:id/jobs/:job_id and this is why we don't have a refresh mixin for that one.

from python-gitlab.

While trying to understand the code to find a better fix for the above, I noticed that ProjectJob's .play() also doesn't update the job status; #2784 fixes that

from python-gitlab.

I don't understand why ProjectPipelineJob exists though; why doesn't ProjectPipelineJobManager.list() return a list of ProjectJob?
That would resolve a bunch of limitations, and I don't see the downside/blocker for doing that, so I must be missing something 😅

from python-gitlab.

@1ace with #2784 merged, does this cover your use case along with the docs above?

from python-gitlab.