Welcome! about diamond HOT 16 OPEN

good idea @kormoc ,
i would suggest a more nuanced approach though: commit/push directly when you're pretty sure the commit is the right way forward and won't cause complaints, and still file PR's in case of doubt or if something might break compatibility.

from diamond.

Yeah, I love me my peer reviews as well. But we can now review each other's
code
Pada 30 Apr 2014 20:44, "Dieter Plaetinck" [email protected]
menulis:

good idea @kormoc https://github.com/kormoc ,
i would suggest a more nuanced approach though: commit/push directly when
you're pretty sure the commit is the right way forward and won't cause
complaints, and still file PR's in case of doubt or if something might
break compatibility.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/2#issuecomment-41797504
.

from diamond.

btw @kormoc if i were you, i would delete this repo, move brightcoveos/diamond to here, and then fork this back to brightcoveos/diamond; doing it via a move means issues, wiki, watchers, stars, etc get moved properly. and it's more clear which is the authorative upstream version and you can still maintain a fork for brightcove.

from diamond.

+1 on the transfer the repository

from diamond.

Sadly, I just can't :(

I've never worked for brightcove and ever contact I have there is gone. I've been unable to reach the right people to get you folks added directly to the repo as developers and I don't have the permissions to move the repo around. I'll keep trying, but I don't believe things will change.

from diamond.

I don't know how to handle git submodules well enough, but we should move the BrightcoveOS wiki to this repo, no?

from diamond.

@Lacrymology Done. :)

from diamond.

I can be a BC contact. @kormoc -- will contact you outside this issue.

from diamond.

@kormoc - I hope I'm not stealing this thread, but should issues and PRs be re-open against this repo?

Thanks.

from diamond.

@zstyblik you should issue PRs here

from diamond.

Thanks @mzupan, but that's not what I'm asking about. I'm asking whether issues and PRs from https://github.com/BrightcoveOS/Diamond should be re-opened here(and probably closed there).

Of course, I will open new issues and PRs here in the future.

from diamond.

@aronatkins @kormoc news on moving BrightcoveOS/Diamond here including issues/PR/etc as @Dieterbe suggested? that'd make things much more clear on what development to follow

thanks!

from diamond.

@kormoc I still have some contacts there. I'm sending you an email to the address listed on your github profile.

from diamond.

@ccope -- I hooked @kormoc up with Brian F. at Brightcove while I was still there. Brian's one of the BrightcoveOS admins. Not sure if that ever went anywhere. I've just left Brightcove myself, but can help still work to get the repo migrated if that's still needed. Feel free to CC me on anything.

from diamond.

Oh my, we have passing tests again!

from diamond.

@kormoc Thoughts on closing old PRs in the brightcove repo? And maybe changing the readme so that people stop referring to it?

from diamond.