NetAppCollector expects arguments to collect() method about diamond HOT 2 CLOSED

Hello,

I have the same issue here ...
I have try another "netapp collector" , wihtout success ... can you test it plz ?
https://github.com/SpringerPE/diamond-ontapclustercollector

I'm using diamond version 4.0.181

Thank you in advance.

from diamond.

Hello @powo, @Gug42,

I can see that this still remains a problem (and only for this specific collector):

netapp/netapp.py:    def collect(self, device, ip, user, password):
netapp/netappDisk.py:    def collect(self, device, ip, user, password):
netapp/netapp_inode.py:    def collect(self, device, ip, user, password):

I don't know much about the history of diamond or how this collector remains in the current state that it's in (and I unfortunately I don't have the cycles to study the git log), but I think it's reasonable to assert that this collector wasn't updated whenever the collect api changed.

If you'd still like to see this work, device, ip, user, password can be removed from the method signature and where they are referenced in the method's implementation, replace the ref with self.config.get(device, etc) instead, as these values are expected to exist as part of the config.

Even with the above suggestion though, the code needs a lot of TLC, for instance, on every invocation of collect, there's a try - except block where the code attempts to import some netapp library - this is something that should be done when the collector is initally loaded, not on every collection which could be as much as every second.

Anyhow, @josegonzalez , can this issue be closed please? (If there is still interest in this plugin, please feel free to contribute by opening a new issue/pr.)

from diamond.