Comments (1)
I'd say it's a bug.
Semantically, the signal request
should provide a full usable request. But we need a way to intercept the request without loading the body, and the plan is to add a headers
signal that is sent once headers are fully parsed (so one can check auth and such at this moment, without dealing with the body).
Here is the original PR, and what we should implement back I think: https://github.com/pyrates/roll/pull/77/files#diff-2b45f513911dff50c92a6d00c244b62aR62-R70
cc @davidbgk I'll try to have a look but I'm not sure I'll have time this week so if you have a slot, go for it :)
Thanks for the report @Natim :)
from roll.
Related Issues (20)
- 404 missing from logger
- websockets HOT 4
- Roll on Curio HOT 2
- Catch HttpParserInvalidMethodError HOT 2
- HTTP/2 support HOT 1
- ImportError: cannot import name 'HttpParserUpgrade' from 'httptools' HOT 6
- Cors wildcard does not allow some methods
- Headers HOT 5
- View HOT 4
- Access-Control-Allow-Headers wildcard rejected in Firefox HOT 3
- Illegal escape sequences in string
- Allow websockets 8.0.2
- Document how to handle views in multiple different python files? HOT 4
- File API for streamed Response ?
- url_for helper to build URLs HOT 2
- Custom exceptions
- url_for `already exist` errors when using decorators HOT 1
- url_for and routes defined twice HOT 2
- Dependabot couldn't authenticate with https://pypi.python.org/simple/
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from roll.