I am creating a plot using the PColorMeshItem over time (i have a tim

pg.PColorMeshItem crashes when x, y array shapes are changed (setData(x, y, z...)). about pyqtgraph HOT 2 CLOSED

Ouam74 commented on June 22, 2024

pg.PColorMeshItem crashes when x, y array shapes are changed (setData(x, y, z...)).

from pyqtgraph.

Comments (2)

pijyoi commented on June 22, 2024

I think both branches below that are testing for "shape changed" are problematic in their own way:

pyqtgraph/pyqtgraph/graphicsItems/PColorMeshItem.py

Lines 228 to 233 in fa26ece

 elif len(args)==1: 

 if args[0].shape[0] != self.x[:,1][-1] or args[0].shape[1] != self.y[0][-1]: 

 shapeChanged = True 

 elif len(args)==3: 

 if np.any(self.x != args[0]) or np.any(self.y != args[1]): 

 shapeChanged = True

The 3-argument branch, which is the one concerned in this issue, could be fixed by using functions.eq():

pyqtgraph/pyqtgraph/functions.py

Lines 642 to 644 in fa26ece

  4. When comparing arrays, returns False if the array shapes are not the same. 

  5. When comparing arrays of the same shape, returns True only if all elements are equal (whereas 

  the == operator would return a boolean array).

from pyqtgraph.

pijyoi commented on June 22, 2024

The existing "shapeChanged" logic was before "dataBounds" was implemented.
What is really wanted is to check if the data bounds have changed. i.e. "shapeChanged" is actually a misnomer.

old_bounds = self._dataBounds
self._prepareData(args)
shapeChanged = old_bounds != self._dataBounds

from pyqtgraph.

pg.PColorMeshItem crashes when x, y array shapes are changed (setData(x, y, z...)). about pyqtgraph HOT 2 CLOSED

Comments (2)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	elif len(args)==1:
	if args[0].shape[0] != self.x[:,1][-1] or args[0].shape[1] != self.y[0][-1]:
	shapeChanged = True
	elif len(args)==3:
	if np.any(self.x != args[0]) or np.any(self.y != args[1]):
	shapeChanged = True

	4. When comparing arrays, returns False if the array shapes are not the same.
	5. When comparing arrays of the same shape, returns True only if all elements are equal (whereas
	the == operator would return a boolean array).