Comments (3)
Raising an exception when the regex matching fails is sufficient, we don't need a standalone function to do that. It's different from record validation because when it doesn't match the pattern, the entry point is invalid and it's better to abort.
As in raising an exception in the existing function that is more specific than an AssertionError? That works for me as long as it is more clear what the problem is to the user in the error message. I am imagining something similar to the message printed when a RECORD file is invalid...
"Invalid entry point in {wheel}. Please report to the maintainers of that package so they can fix their project setup. Details: \n{formatted_issues}\n"
... followed by aborting the install. That, of course would be up to users of this library to catch and print / re-throw (i.e. pdm
), and the only change here would be the more specific error to be raised.
from installer.
Raising an exception when the regex matching fails is sufficient, we don't need a standalone function to do that. It's different from record validation because when it doesn't match the pattern, the entry point is invalid and it's better to abort.
from installer.
I ran into that error after renaming the package. However, assert match AssertionError
is nothing a user can work with. I had to read through the code to get what's the problem here.
from installer.
Related Issues (20)
- Always normalize RECORD files to forward-slash when writing HOT 1
- Update the `simple_launcher` script wrappers
- data_dir heuristics
- Installer compiles bytecode for wrong python version HOT 5
- prefix always ends with /local/ on ubuntu HOT 3
- Record validation fails on invalid hash algorithm names
- GUI script should use pythonw.exe instead of python.exe on Windows
- 0.7.0: issue with installing `pecan` .whl archive HOT 1
- RECORD file validation loads the entire file in memory
- Compute wheel content hashes once
- --libdir options missing HOT 1
- `data_dir` lacks optional build tag HOT 2
- Unable to install salt wheel HOT 1
- Move to PyPA org on PyPI? HOT 1
- Support checking install dependencies HOT 11
- Security Address HOT 1
- RFE: add handle `--user` switch HOT 4
- Add `--force` option
- Release for use with Python 3.13 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from installer.