Git Product home page Git Product logo

Comments (10)

fafhrd91 avatar fafhrd91 commented on June 1, 2024

from tokio.

jettify avatar jettify commented on June 1, 2024

With tokio loop I am getting bunch of errors RuntimeError: Timeout context manager should be used inside a task when using loop.run_until_complete(coro) as result tests does not have a chance to start since such idiom ofter used in test fixtures. (asyncio and uvloop works as expected)

    @pytest.fixture
    def bucket_name(region, create_bucket, s3_client, loop):
>       name = loop.run_until_complete(create_bucket(region))
E       RuntimeError: Timeout context manager should be used inside a task

from tokio.

fafhrd91 avatar fafhrd91 commented on June 1, 2024

from tokio.

1st1 avatar 1st1 commented on June 1, 2024

Does tokio create its own rust Tasks? Why not Futures instead?

from tokio.

fafhrd91 avatar fafhrd91 commented on June 1, 2024

@jettify aiomonitor passes tests with aiohttp master

from tokio.

fafhrd91 avatar fafhrd91 commented on June 1, 2024

from tokio.

jettify avatar jettify commented on June 1, 2024

I will merge those PRs soon, so tokio/uvloop can be tested on each PR continuously.

from tokio.

fafhrd91 avatar fafhrd91 commented on June 1, 2024

@jettify I think we need separate package for various asyncio related fixtures.
every library that test different event loops implements loop fixture

from tokio.

jettify avatar jettify commented on June 1, 2024

@fafhrd91 agreed there are few libraries, but not sure I like them (https://pypi.python.org/pypi/pytest-asyncio)

from tokio.

fafhrd91 avatar fafhrd91 commented on June 1, 2024

But we have enough fixters in aiohttp and other aio libs, we just need to extract those to separate package

from tokio.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.