Comments (14)
I believe that maturin 1.5 no longer detects 3.13, so maybe start by retrying?
Didn’t see it was released! It now works without the environ variable trick: jeertmans/DiffeRT#67.
Thank you!
from maturin.
@jeertmans as a late follow-up here, the point of the PyO3 change is to protect people from shipping builds which might be horribly broken due to lack of support.
I would recommend un-pinning PyO3 and instead set the environment variable
PYO3_USE_ABI3_FORWARD_COMPATIBILITY=1
like the error message suggests.If the build doesn't succeed with that environment variable set, then either:
- PyO3 has a bug or some functionality missing with
abi3
, please report that as a PyO3 issue- The fact you have a successful build at the moment suggests that your 3.13 alpha build is at risk of being broken as soon as a newer alpha comes along.
@davidhewitt thanks for the clarification! Looks like this also fixes the previous issues, see jeertmans/DiffeRT#59. I would tend to prefer this fix over the above one, as I do not need to restrict the pyo3 version with this one :-)
from maturin.
Hi @davidhewitt, sorry about this. I forgot to upgrade Maturin. Maturin 1.5 and pyo3 0.20.3 works fine.
from maturin.
This is due to PyO3/pyo3#3821, consider commit your Cargo.lock
to avoid such breakage.
from maturin.
This is due to PyO3/pyo3#3821, consider commit your
Cargo.lock
to avoid such breakage.
Should I also pin to a specific version? Because just committing Cargo.lock
didn't fix: jeertmans/DiffeRT#56 (or directly https://github.com/jeertmans/DiffeRT/actions/runs/8062290415/job/22021733511?pr=56).
from maturin.
Should I also pin to a specific version?
Yeah, pin to pyo3 <= 0.20.2, generating the lock file now will update to 0.20.3 which contains the version check.
Generally speaking, you should commit Cargo.lock
for reproducibility.
from maturin.
Should I also pin to a specific version?
Yeah, pin to pyo3 <= 0.20.2, generating the lock file now will update to 0.20.3 which contains the version check.
Thanks, it now works!
Generally speaking, you should commit
Cargo.lock
for reproducibility.
I generally do, but I thought it was not so important for this project, so I removed it to "clean a bit the repo", but I get it serves some purposes.
from maturin.
@jeertmans as a late follow-up here, the point of the PyO3 change is to protect people from shipping builds which might be horribly broken due to lack of support.
I would recommend un-pinning PyO3 and instead set the environment variable PYO3_USE_ABI3_FORWARD_COMPATIBILITY=1
like the error message suggests.
If the build doesn't succeed with that environment variable set, then either:
- PyO3 has a bug or some functionality missing with
abi3
, please report that as a PyO3 issue - The fact you have a successful build at the moment suggests that your 3.13 alpha build is at risk of being broken as soon as a newer alpha comes along.
from maturin.
@messense maybe in maturin-action
we should try to be smart about whether to find 3.13 alpha releases? It is probably not a good idea to be uploading alpha wheels to PyPI unless they are using abi3 only...
from maturin.
What should we update to the CI yaml?
from maturin.
I believe that maturin 1.5 no longer detects 3.13, so maybe start by retrying?
from maturin.
Thanks @davidhewitt
from maturin.
![Screenshot 2024-03-18 at 20 42 50](https://private-user-images.githubusercontent.com/3055936/313682506-8046eb5b-0410-45f2-bf25-7825ce884b0a.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjIxMzMxODUsIm5iZiI6MTcyMjEzMjg4NSwicGF0aCI6Ii8zMDU1OTM2LzMxMzY4MjUwNi04MDQ2ZWI1Yi0wNDEwLTQ1ZjItYmYyNS03ODI1Y2U4ODRiMGEucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDcyOCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA3MjhUMDIxNDQ1WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NDEzNTFjM2Q1MDBkOTg4MDgyOWEwMjE2NjA1MjQzMmQ0MjIzNGM2YmRlZjgzOWYxODA1ZWUwYWM1MGZiMjNmNiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.xS45Q3TwWBUAXeSe4_R9KrvVMKJYv8AoLBtSAWctA5o)
from maturin.
@victorteokw can you share job logs?
from maturin.
Related Issues (20)
- RECORD file is missing entries for some files HOT 7
- Windows aarch64 build fails: "no cab files were referenced by the MSI" HOT 2
- Adapt rustc 1.79 HOT 1
- Package Independent Configuration
- Generated Github release workflow does not build wheels for Python 3.8 - 3.10 for MacOS HOT 1
- Maturin is buggy when Cargo.toml sets `license-file.workspace = true` HOT 1
- Building sdist fails if a crate in workspace isn't used HOT 1
- cross-compiling to win no longer possible with the new sdk HOT 2
- Install rust toolchain on building source distribution HOT 7
- use of base python in pep517 builds breaks eg pydantic-core HOT 1
- Build Failed in old MacOS version HOT 1
- Regression in cffi binding in 1.6 HOT 2
- Mixted rust/python project fails to install on windows with maturin 1.7 HOT 3
- v1.7.0 from v1.6.0 introduces a rustls version conflict preventing v.1.7.0 from compiling HOT 1
- Support for different package managers like poetry, uv, rye HOT 1
- CentOS 7 Deprecation & Possibility to upgrade base image HOT 1
- Issue with README building sdist
- Build succeeds but wheel is broken on cross compile.
- Incompatible with conda or venv, with error "markers XXX don't match your environment" HOT 2
- Add a way to override the resultant Python package version
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from maturin.