Git Product home page Git Product logo

Comments (14)

jeertmans avatar jeertmans commented on July 28, 2024 2

I believe that maturin 1.5 no longer detects 3.13, so maybe start by retrying?

Didn’t see it was released! It now works without the environ variable trick: jeertmans/DiffeRT#67.

Thank you!

from maturin.

jeertmans avatar jeertmans commented on July 28, 2024 1

@jeertmans as a late follow-up here, the point of the PyO3 change is to protect people from shipping builds which might be horribly broken due to lack of support.

I would recommend un-pinning PyO3 and instead set the environment variable PYO3_USE_ABI3_FORWARD_COMPATIBILITY=1 like the error message suggests.

If the build doesn't succeed with that environment variable set, then either:

  • PyO3 has a bug or some functionality missing with abi3, please report that as a PyO3 issue
  • The fact you have a successful build at the moment suggests that your 3.13 alpha build is at risk of being broken as soon as a newer alpha comes along.

@davidhewitt thanks for the clarification! Looks like this also fixes the previous issues, see jeertmans/DiffeRT#59. I would tend to prefer this fix over the above one, as I do not need to restrict the pyo3 version with this one :-)

from maturin.

victorteokw avatar victorteokw commented on July 28, 2024 1

Hi @davidhewitt, sorry about this. I forgot to upgrade Maturin. Maturin 1.5 and pyo3 0.20.3 works fine.

from maturin.

messense avatar messense commented on July 28, 2024

This is due to PyO3/pyo3#3821, consider commit your Cargo.lock to avoid such breakage.

from maturin.

jeertmans avatar jeertmans commented on July 28, 2024

This is due to PyO3/pyo3#3821, consider commit your Cargo.lock to avoid such breakage.

Should I also pin to a specific version? Because just committing Cargo.lock didn't fix: jeertmans/DiffeRT#56 (or directly https://github.com/jeertmans/DiffeRT/actions/runs/8062290415/job/22021733511?pr=56).

from maturin.

messense avatar messense commented on July 28, 2024

Should I also pin to a specific version?

Yeah, pin to pyo3 <= 0.20.2, generating the lock file now will update to 0.20.3 which contains the version check.

Generally speaking, you should commit Cargo.lock for reproducibility.

from maturin.

jeertmans avatar jeertmans commented on July 28, 2024

Should I also pin to a specific version?

Yeah, pin to pyo3 <= 0.20.2, generating the lock file now will update to 0.20.3 which contains the version check.

Thanks, it now works!

Generally speaking, you should commit Cargo.lock for reproducibility.

I generally do, but I thought it was not so important for this project, so I removed it to "clean a bit the repo", but I get it serves some purposes.

from maturin.

davidhewitt avatar davidhewitt commented on July 28, 2024

@jeertmans as a late follow-up here, the point of the PyO3 change is to protect people from shipping builds which might be horribly broken due to lack of support.

I would recommend un-pinning PyO3 and instead set the environment variable PYO3_USE_ABI3_FORWARD_COMPATIBILITY=1 like the error message suggests.

If the build doesn't succeed with that environment variable set, then either:

  • PyO3 has a bug or some functionality missing with abi3, please report that as a PyO3 issue
  • The fact you have a successful build at the moment suggests that your 3.13 alpha build is at risk of being broken as soon as a newer alpha comes along.

from maturin.

davidhewitt avatar davidhewitt commented on July 28, 2024

@messense maybe in maturin-action we should try to be smart about whether to find 3.13 alpha releases? It is probably not a good idea to be uploading alpha wheels to PyPI unless they are using abi3 only...

from maturin.

victorteokw avatar victorteokw commented on July 28, 2024

What should we update to the CI yaml?

from maturin.

davidhewitt avatar davidhewitt commented on July 28, 2024

I believe that maturin 1.5 no longer detects 3.13, so maybe start by retrying?

from maturin.

victorteokw avatar victorteokw commented on July 28, 2024

Thanks @davidhewitt

from maturin.

victorteokw avatar victorteokw commented on July 28, 2024
Screenshot 2024-03-18 at 20 42 50 This problem still exists. It tries to find Python 3.13 only on this system like before.

from maturin.

davidhewitt avatar davidhewitt commented on July 28, 2024

@victorteokw can you share job logs?

from maturin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.