Comments (10)
If no one is working on this I can do it
from pylint.
I made a dummy test with my PR changes:
https://github.com/zoftko/balba/pull/2/files
Just wondering if we should mark all annotations as error? Or make some sort of mapping between pylint message types and github annotation types.
For example Pylint has fatal, error, warning, convention, refactor and information type messages. Github has notice, warning and error annotations.
from pylint.
I think trying if this works with a template would be nice. Then we can just document that in the documentation.
Once it works as template string, maybe it'd still be beneficial to have something like github
available as key one can pass to the --output-format
(or a similiar?) flag such that users won't have to add something like
pylint --msg-template='{msg_id}:{line:3d},{column}: {obj}: {msg}' # example from the docs
and can instead simply go ahead and run
pylint --output-format=github # or a similar cli flag
without having to know the "internals" of how the messages are to be outputted in order to be GitHub-action-consumable? But maybe that's just me being too lazy as a user.
from pylint.
No I think that is fair. We have recently added a new json
reporter. You can probably look at that PR to see what stuff you'd need to add for it to work.
I'm on mobile right now so can't easily link the PR myself, sorry!
from pylint.
Thank you for opening this issue, great suggestion !
from pylint.
So I was checking the code and it seems like this could be done with --msg-template, in fact some reporters are marked as deprecated and suggest using --msg-template directly instead. Would this be the same case?
from pylint.
I think trying if this works with a template would be nice. Then we can just document that in the documentation. You could start there?
from pylint.
I also like the shortcut. Lazy users are the best users 😄
Here's hopefuly a link to the code of json reporters (other exemples are available in this directory) : https://github.com/pylint-dev/pylint/blob/main/pylint%2Freporters%2Fjson_reporter.py
from pylint.
It looks really great. I think pylint fatal should break the build, error should be mapped to error, warning to warning and pylint convention and refactor to github's notice.
from pylint.
@crazybolillo Many thanks for the quick implementation and thanks to everyone involved in the PR ❤
from pylint.
Related Issues (20)
- Crash F0002 AstroidError due to possibly undefined loop variable HOT 1
- C0325 (superfluous-parens) appears to not trigger when contents are a string
- Inconsistency between used-before-assignment and possibly-used-before-assignment for if/elif/else HOT 1
- possibly-used-before-assignment for function that is checked for call ability before calling HOT 2
- `too-few-function-args` overlaps with `no-value-for-parameter`
- Inconsistent and sometimes incorrect false positive of `no-member` error HOT 9
- `redefined-outer-name` (`W0621`) - false positive on 3.12 type aliases
- False positive missing member __value__ with type statement and Literal under python 3.12
- Pylint Crash when building the AST of a dataclass with a `Any` member field HOT 2
- Behavior of --prefer-stubs HOT 3
- False positive for protected-access / W0212 in a very simple class HOT 3
- False Negative function-redefined when function named with leading underscore HOT 3
- Dynamic color mapping for "fail-on" messages/categories in ColorizedTextReporter HOT 1
- RecursionError when analyzing sqlalchemy's code HOT 1
- Clarify `no-else-raise` and `no-else-return` also apply to try/except HOT 1
- False positive `invalid-overridden-method` when overridding `Enum.value`
- False positive E1126 (invalid-sequence-index) on generic type alias with forward ref HOT 3
- pylint treats `package.module` same as `package/module.py` in terms of search HOT 7
- False positive `inconsistent-return-statements` with `typing.assert_never` HOT 4
- False positive unexpected-keyword-arg (E1123) HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pylint.