Feature Request: Naming Convention Enforcement for Boolean Values & Functions about pylint HOT 8 CLOSED

Yes, the PR to see the primer could be in @rhyn0 's fork. I approve the pipeline in pylint-dev/pylint from time to time if it can help @rhyn0 to see the primer result faster/easier, though it does not mean we're going to add an extension, it should stay a plugin.

from pylint.

The code does not look too complicated, great plugin. You could add it to your fork of pylint as and extension and open a merge request to your main branch to see what's happening in the primers (numpy, pandas, pytest, etc. ). To likely find a bunch of false positives easily. We can add this to pylint-dev if you wish when it's ready.

from pylint.

Sounds like a nice idea for a third-party plugin. The plugin author can decide how to define "boolean function" -- analyze the return statements, the type annotation, what happens if two different things are returned, or there's an implicit None return...? etc.

from pylint.

I agree with Jacob, it rather complicated to specify and maintain and more suited to an (opinionated) plugin (or for a linter targeting a strongly typed language). If we add this to pylint we'll have to handle a lot of use case with a myriad of options because we want pylint to be one size fit all after configuration.

from pylint.

for anyone who does want something like this, I took a crack at it and built it here https://github.com/rhyn0/pylint-boolean-naming

Comments appreciated

from pylint.

@Pierre-Sassoulas I think you meant to suggest to add the repository to pylint-dev right? Not in a PR like #9438

from pylint.

@Pierre-Sassoulas sorry about that, thanks for explaining your original message. And another thanks for the primer workflow stuff.

I'm unsure what the "merge into pylint-dev" looks like (organization forks my repo and then that becomes the source?) but I'll try to get the primer run to work first

from pylint.

No problems :) You can create a branch on your fork (rhyn0/fork-branch) and open a merge request to your own main branch from your fork (rhyn0/main) then the pipeline should work (provided the primer run once on the main branch). Happy to keep approving the pipeline on #9438 if you have issue with your fork setup.

from pylint.