pygame-1.9.1release - endian problem saving an image in png format about pygame HOT 7 CLOSED

Original comment by Thomas Kluyver (Bitbucket: takluyver, GitHub: takluyver):

Removing version: unspecified (automated comment)

from pygame.

Original comment by René Dudfield (Bitbucket: illume, GitHub: illume):

Merged in OPiMedia/pygame (pull request #30)

Bug fix: Red and green channels inversion on AMD 64 (see issue #39).

from pygame.

Original comment by René Dudfield (Bitbucket: illume, GitHub: illume):

Bug fix: Red and green channels inversion on AMD 64 (see issue #39).

from pygame.

Original comment by René Dudfield (Bitbucket: illume, GitHub: illume):

Merged in OPiMedia/pygame (pull request #30)

Bug fix: Red and green channels inversion on AMD 64 (see issue #39).

from pygame.

Original comment by Olivier Pirson (Bitbucket: OPiMedia, GitHub: OPiMedia):

I have the same problem (save PNG reverse channels) with this configuration:

• Debian Wheezy AMD 64
• Python 3.2.3 (default, Feb 20 2013, 14:44:27) [GCC 4.7.2]
• Pygame 1.9.2a0

It's ok with:

• Python 2.7.3 (default, Mar 13 2014, 11:03:55) [GCC 4.7.2]
• Pygame 1.9.1release

from pygame.

Original comment by René Dudfield (Bitbucket: illume, GitHub: illume):

Fixed SDL_BIG_ENDIAN bug for png write. Fixes and closes #39

from pygame.

Original comment by René Dudfield (Bitbucket: illume, GitHub: illume):

Thanks Jens.

Here is the test code inline the comment to make it easier to see.

import pygame, os
from pygame.locals import *

# Set SDL to use the dummy NULL video driver,
#   so it doesn't need a windowing system.
os.environ["SDL_VIDEODRIVER"] = "dummy"

if True:
    # Some platforms need to init the display for some parts of pygame.
    import pygame.display
    pygame.display.init()
    screen = pygame.display.set_mode((1,1))

def main():
    test = pygame.Surface((256, 256), flags=SRCALPHA, depth=32)
    for y in xrange(256):
        for x in xrange(256):
            test.set_at((x, y), (x,y,(x + y) % 256, (((x ^ y) >> 4) & 1) * 127 + 128))
    for ext in ["tga", "png", "bmp", "jpg"]:
        pygame.image.save(test, "test.%s" % ext)

if __name__ == "__main__":
    main()

It seems the set_at() call does some bit fiddling, which I'm weary of.

Also need to confirm this fails on PPC, which I don't have access too test on.

The test could be changed to read the lossless formats like tga, png and bmp to make sure they read back the colours correctly. Then this could be used as a unit test easily.

from pygame.