Git Product home page Git Product logo

Comments (9)

nicolasdlss avatar nicolasdlss commented on August 27, 2024 1

To conform to the documentation structure used up to now, the documentation on the single solver, should be part of the coupled_solvers.md file. Next to that there should be a test_single_solver.md file in the corresponding example folder. In this way, there are no files with identical names.
I will try to have a look a the pull request later today.

from coconut.

nicolasdlss avatar nicolasdlss commented on August 27, 2024

Now the function providing dummy data is called test_function.py. To avoid confusion, to make it more pythonic and to be able to run in the gui, I would suggest to change the name of the file such that it no longer starts with test.

from coconut.

toondm avatar toondm commented on August 27, 2024

Good point, it shouldn't have the same name as a unit-test file.

What do you mean with running in the GUI @nicolasdlss ?

from coconut.

awbral avatar awbral commented on August 27, 2024

I changed its name to functions.py, hope this works for you? Follow updates in the documentation_test_single_solver branch.

from coconut.

nicolasdlss avatar nicolasdlss commented on August 27, 2024

@toondm Probably there is a workaround, but in Pycharm if you want to run a script which starts with test, it automatically runs it using pytest. Just a detail as another reason why the name should change.

@awbral Maybe functions.py is a little to generic. It is good practice, to let the name clearly state what the function is/does, so as long as we are changing the name, maybe we could go for dummy_solver.py? What do you think?
I will also make some small changes to the code (I noticed some small issues and also the printing at the end fails), but in a new branch maybe.

from coconut.

awbral avatar awbral commented on August 27, 2024

yes, I noticed the fail too, wanted to look into that.

dummy_solver.py is actually a pretty good name! Maybe I can change that now? You could make a new branch, but then also change the name of test_function.py in test_single_solver.py, or continue in the branch I'm working on?

from coconut.

nicolasdlss avatar nicolasdlss commented on August 27, 2024

I will do it in a separate branch, to let the name of the branch reflect its purpose. And will pull in your branch, maybe after merging it with the master? Or do you still have a lot of work before you can merge?

from coconut.

awbral avatar awbral commented on August 27, 2024

At this point, the documentation file of the example "test_single_solvers" has the same name as the documentation about this functionality itself, namely 'test_single_solvers.md'. Shouldn't this change in order to be able to render properly?

from coconut.

toondm avatar toondm commented on August 27, 2024

Yes, that is one of the requirements of mkdocs: all MD files must have different names.
The underlying reason is that all MD files are converted to file index.html, located in a folder of the given name. All these folder are at the same level of the static HTML website as you can see in the gh-pages branch.
I think run_mkdocs.py gives an error if you try to build the website this way.

from coconut.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    šŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. šŸ“ŠšŸ“ˆšŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ā¤ļø Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.