Comments (9)
To conform to the documentation structure used up to now, the documentation on the single solver, should be part of the coupled_solvers.md
file. Next to that there should be a test_single_solver.md
file in the corresponding example folder. In this way, there are no files with identical names.
I will try to have a look a the pull request later today.
from coconut.
Now the function providing dummy data is called test_function.py
. To avoid confusion, to make it more pythonic and to be able to run in the gui, I would suggest to change the name of the file such that it no longer starts with test.
from coconut.
Good point, it shouldn't have the same name as a unit-test file.
What do you mean with running in the GUI @nicolasdlss ?
from coconut.
I changed its name to functions.py
, hope this works for you? Follow updates in the documentation_test_single_solver branch.
from coconut.
@toondm Probably there is a workaround, but in Pycharm if you want to run a script which starts with test
, it automatically runs it using pytest. Just a detail as another reason why the name should change.
@awbral Maybe functions.py
is a little to generic. It is good practice, to let the name clearly state what the function is/does, so as long as we are changing the name, maybe we could go for dummy_solver.py
? What do you think?
I will also make some small changes to the code (I noticed some small issues and also the printing at the end fails), but in a new branch maybe.
from coconut.
yes, I noticed the fail too, wanted to look into that.
dummy_solver.py
is actually a pretty good name! Maybe I can change that now? You could make a new branch, but then also change the name of test_function.py
in test_single_solver.py
, or continue in the branch I'm working on?
from coconut.
I will do it in a separate branch, to let the name of the branch reflect its purpose. And will pull in your branch, maybe after merging it with the master? Or do you still have a lot of work before you can merge?
from coconut.
At this point, the documentation file of the example "test_single_solvers" has the same name as the documentation about this functionality itself, namely 'test_single_solvers.md'. Shouldn't this change in order to be able to render properly?
from coconut.
Yes, that is one of the requirements of mkdocs: all MD files must have different names.
The underlying reason is that all MD files are converted to file index.html, located in a folder of the given name. All these folder are at the same level of the static HTML website as you can see in the gh-pages branch.
I think run_mkdocs.py gives an error if you try to build the website this way.
from coconut.
Related Issues (20)
- Syncing processors in OpenFOAM
- Test scaling of interface data for block quasi-Newton methods
- Transformer mapper to perform a general transformation operation
- Transformer mapper for scaling data
- Setting the number of cores used by Kratos Multiphysics with OpenMP
- Make O(nĀ²) operation more efficient
- Improve tests HOT 3
- BreakingDam example does not restart in newer versions of Fluent HOT 2
- Single Fluent UDF file
- The check_bounding_box tool in the mappers doesn't take into the mapping direction
- Save results with pickle file becomes slow in case of a large number of time steps HOT 1
- Providing an estimate of the time required to save data for post-processing would provide interesting insights
- The documentation of the coupled solvers can be restructured to more clearly link with the methods in literature
- Change the behavior of test_single_solver with respect to the CFD and CSM folders
- The ReadMe.md contains a typo; there is no folder "coconut/examples/tube_tube_flow_tube_structure/" HOT 1
- Fluent journal settings not compatible with energy equation
- Fluent multi-node on HPC
- Multinode does not work for Fluent 2024R1 (UGent HPC issue)
- Remove MPI-clauses in USR.f and USRInit.f
- Multiphase OpenFOAM example
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
š Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ššš
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ā¤ļø Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from coconut.