Comments (3)
Marking resolved as the specific test case noted as a possible failure has now been resolved, and I can't personally think of a situation where the parsing would now fail. Thanks again for your input!
I will look further into switching to using the Python tokenizer in the future - however my immediate reaction is admittedly a little weary as it seems like that could reduce the performance of parsing (as it would add an entire additional pass over the file contents) and so far it seems pretty straight forward and testable to parse out just strings manually. That said, it could be super fast and my custom parsing of strings could be further broken yet. I am often incorrect and there is no guarantee this is an exception :)
Thanks!
Timothy
from isort.
Well, I think I could come up with counter examples all day. :)
For example, this
import os
'''
\'''
import junk
'''
gets corrupted by isort
into
import os
import junk
'''
\'''
'''
from isort.
This issue has been solved in release 2.4.1 Thanks!
from isort.
Related Issues (20)
- Non-idempotency with commented multiline imports
- [self tests] test_black_pyi_file fails with black 24.2.0
- [self tests] test_isort_should_warn_on_empty_custom_config_issue_1433 fails against Pytest 8
- `--skip-gitignore` still traverses files/directories in .gitignore'd directories HOT 2
- Sorting order is broken and not following standard sort order HOT 13
- Third-party incorrectly identify as First-party depending on the name of the root directory
- isort.core.process incorrectly returns False if only changes to lines before imports were made, with no changes to raw import section
- Ran into `ERROR: Unrecoverable exception thrown when parsing <filepath>`
- Feature Request: Improved Handling of `# type: ignore` Comments to Preserve Mypy Compatibility HOT 1
- Different order on same file depending on where you execute isort v5.13.2 HOT 1
- THIRDPARTY module detected as FIRSTPARTY when import happens within subdir of same name
- Black line length config support when using `--profile black`? HOT 1
- isort does not recognize _collections_abc as part of the standard library HOT 1
- Unrecoverable exception thrown using --sort-reexports
- Feature Request: Automatic Conversion of Relative Imports to Absolute Imports
- isort doesn't format the imports in PyCharm's Jupyter notebooks
- False order of local imports relative to standard library imports
- Circular Import Issue Due to Import Reordering in Python 3.8
- Bug : isort add empty lines before pylint comments
- Deprecate `setuptools` integration comand
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from isort.