Comments (4)
Thanks for reporting this! Will fix before the next release. Pretty sure at this point I need a contributors file, if only to acknowledge the fact you've helped find / fix and improve a bunch of things about isort.
~Tim
from isort.
Hi @Bengt,
Thanks again for letting me know about this issue, it's been fixed in isort release 3.6.2.
Additionally, I've created and added you to an ACKNOWLEDGEMENTS.md file:
https://github.com/timothycrosley/isort/blob/develop/ACKNOWLEDGEMENTS.md
~Tim
from isort.
Thanks for fixing this, adding me to the acknowledgments file and being awesome in general. I use isort in a project at work and report anything that comes up. Your quick fixes made isort a very valuable tool for us.
Speaking of which, how about a list of projects using isort, like reveal.js does. A quick search shows that there are already some projects with make targets for isort on GitHub. One could use the wiki for it and encourage users to add projects themselves. It might be a good idea to create a list of related projects for comparison, like rope. Maybe the plugins would be better kept in the wiki than the README, too.
from isort.
I think that's a great idea. I've done my best to populate that information in the isort wiki, as well as provide a better reference of all possible settings that are available for configuring isort: https://github.com/timothycrosley/isort/wiki
Thanks!
~Tim
from isort.
Related Issues (20)
- Ran into `ERROR: Unrecoverable exception thrown when parsing <filepath>`
- Feature Request: Improved Handling of `# type: ignore` Comments to Preserve Mypy Compatibility HOT 1
- Different order on same file depending on where you execute isort v5.13.2 HOT 1
- THIRDPARTY module detected as FIRSTPARTY when import happens within subdir of same name
- Black line length config support when using `--profile black`? HOT 1
- isort does not recognize _collections_abc as part of the standard library HOT 1
- Unrecoverable exception thrown using --sort-reexports
- Feature Request: Automatic Conversion of Relative Imports to Absolute Imports
- isort doesn't format the imports in PyCharm's Jupyter notebooks
- False order of local imports relative to standard library imports
- Circular Import Issue Due to Import Reordering in Python 3.8
- Bug : isort add empty lines before pylint comments
- Deprecate `setuptools` integration comand
- Docs: GitHub action and Pre-commit need better configuration/args examples HOT 1
- Bug: Word wrapping works incorrectly with force_single_line=True
- isort breaks the code with sort_reexports = true HOT 2
- noqa isn't well respected
- Feature request: per-block sorting strategy (inline sort)
- Isort does not honor skip directories
- `isort` does not move all imports to the top of the file when there are imports after other code blocks
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from isort.