Git Product home page Git Product logo

Comments (4)

timothycrosley avatar timothycrosley commented on May 18, 2024 4

Thanks for reporting this issue, it has been fixed in version 3.5.0 with the addition of the 'lines_after_imports' setting.

~Timothy

from isort.

excitoon avatar excitoon commented on May 18, 2024 1

@timothycrosley lines_after_import=2 does not help in all cases unfortunately:

if sys.version > (3, 8):
  import xxx

  class Abc:
    ...

In this example, I would like to have lai=1 for non-top-level imports. 🤷‍♂️🤷‍♂️🤷‍♂️

from isort.

timothycrosley avatar timothycrosley commented on May 18, 2024

Hi @dwaynebailey,

Thanks for pointing out this area for improvement. Currently, isort does add 2 lines if it sees the next item code construct is a class, decorator, or function - but one line otherwise. To fix the issue you are facing I plan on adding a "lines_after_import" option, that when set to a number of new lines will force this number independent to the code construct that follows.

Thanks!

Timothy

from isort.

dwaynebailey avatar dwaynebailey commented on May 18, 2024

Thanks for all these changes. Tested and seems to be working great.

from isort.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.