Git hook doesn't work about flake8 HOT 6 CLOSED

In GitLab by @sigmavirus24 on Mar 12, 2015, 19:07

Note that strict defaults to false. You need to either follow the instructions in the comments and do

git config flake8.strict true

from flake8.

In GitLab by @Bjwebb on Apr 2, 2015, 10:51

I have this error also.

The error is that the git hook produces no output. Setting strict to true does not help (this only changes whether the commit is allowed to happen).

If I set IGNORE to None, the git hook produces the expected output.

It seems that IGNORE is now set to '' (the default at https://gitlab.com/pycqa/flake8/blob/master/flake8/hooks.py#L191), whereas previously git hooks used os.getenv which returns None by default. If git_hook is run with ignore='' then it seems to ignore all files.

from flake8.

In GitLab by @sigmavirus24 on Apr 2, 2015, 10:56

@Bjwebb you're encountering a separate issue. Please file a new bug for that.

from flake8.

In GitLab by @Bjwebb on Apr 2, 2015, 10:59

I think this is actually the same issue reported here, but happy to file a new bug if you prefer.

from flake8.

In GitLab by @sigmavirus24 on Apr 2, 2015, 11:01

The issue @Suor reported was that they received output but were still able to perform a commit.

from flake8.

In GitLab by @Bjwebb on Apr 2, 2015, 12:04

Sorry, you're right that the reported issue is that they can still perform a commit. It looks like the example does also exhibit the issue I came across (lack of output flake8 from git commit).

I've opened a new bug #52

from flake8.