Comments (5)
hynek
commented on June 4, 2024
1
Like and subscribe #67
from service-identity.
hynek
commented on June 4, 2024
Wouldn’t that be a breaking change?
from service-identity.
adiroiban
commented on June 4, 2024
I think it would be a breaking change that people want :)
Rather than a "silent" error about no match, I think that you want an error about the certificat not having a SAN .
As an application developer, I want to present users with meaningful / actionable error messages.
With the current code, I need to always run a separate check to see if the certificat has a SAN and raise a different error.
from service-identity.
hynek
commented on June 4, 2024
How about a compromise: NoSubjectAltNameFoundError(VerificationError)? Should be 100% backwards-compatible?
from service-identity.
hynek
commented on June 4, 2024
no, wait I spoke to soon. that doesn't work with our multiple errors.
from service-identity.
Related Issues (20)
- reject certificates with unprocessed critical extensions HOT 4
- Support iPAddress in subjectAltName extensions HOT 12
- TypeError: attributes() got an unexpected keyword argument 'apply_with_init' HOT 4
- cryptography.x509 backend HOT 3
- SubjectAltNameWarning is almost impossible to diagnose
- Convert readthedocs link for their .org -> .io migration for hosted projects HOT 1
- Drop pyasn1 dep and use cryptography's x509 support HOT 1
- Undeclared dependency on cryptography.x509 module HOT 11
- Wildcard validation not working for non FQDN / direct hostname HOT 4
- Test suite missing in PyPI tarball HOT 4
- Segmentation fault upon installing service_identity HOT 2
- Provide sdist on pypi. HOT 3
- Incorrect depenceny on attrs>=16.0.0 due to use of attr.ib(converter=)
- IP-Addresses in DNS subjectAltName extension makes verify_certificate_hostname() error out HOT 3
- Error when parsing a certificate with a URI SAN containing multiple colons HOT 8
- consider tagging a new release HOT 2
- VerificationError can't be un-pickled HOT 3
- DNSMismatch errors don't include information about what names the mismatched_id didn't match. HOT 1
- emit a warning when matching the commonName of a certificate HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from service-identity.