Git Product home page Git Product logo

Comments (10)

diggidong avatar diggidong commented on June 2, 2024 1

yeah, but if that hasn't been fixed yet in the main branch intself, then pls don't close that bug issue.

from pwndoc-ng.

Zeecka avatar Zeecka commented on June 2, 2024

I can reproduce, I've got the same issue with original pwndoc too (I don't know if you can confirm).
This is a front-end issue only (it should display correctly in the repport). I'm looking for a fix but I'm not a Vue.js expert :') !

from pwndoc-ng.

burtonc avatar burtonc commented on June 2, 2024

This issues has only recently appeared in my install, now running pwndoc-ng, original pwndoc install about 6 to 8 weeks old is not impacted

upon investigation the export to word shows the scope despite there UI not displaying it.

I’ve proxied the calls, there are 2 API responses returned on the page, first one responds wil scope correctly, second responds empty for scope hosts (I’ll update with my requests later as not in front of that machine)

from pwndoc-ng.

Zeecka avatar Zeecka commented on June 2, 2024

It looks like we have a regression on the API side (I think it's due to a version bump). I'm currently checking if data is altered before insert or on query.

Test on API route

api/audits/<id>/general

Working version

{
    "status": "success",
    "datas": {
        "collaborators": [],
        "reviewers": [],
        "_id": "6421fdbfc56624001175598f",
        "name": "Test",
        "language": "fr",
        "auditType": "Web",
        "creator": {
            "_id": "6421fd80c56624001175598a",
            "username": "admin",
            "firstname": "admin",
            "lastname": "admin"
        },
        "customFields": [],
        "template": "6421fd8cc56624001175598c",
        "scope": [
            "aa",
            "bbb"
        ]
    }
}

Last version

{
    "status": "success",
    "datas": {
        "_id": "6421ff769522ee7a0971f8ae",
        "name": "fr",
        "auditType": "fr",
        "collaborators": [],
        "reviewers": [],
        "language": "fr",
        "template": "6421ff519522ee7a0971f877",
        "creator": {
            "_id": "6421ff379522ee7a0971f861",
            "username": "admin",
            "firstname": "admin",
            "lastname": "admin"
        },
        "customFields": [],
        "scope": [
            {
                "hosts": []
            },
            {
                "hosts": []
            }
        ]
    }
}

from pwndoc-ng.

Zeecka avatar Zeecka commented on June 2, 2024

DB entry is the same on both version (which is coherent with the fact report generation and network section are working).

{
    "_id": ObjectId("64220c47778ed0b87cb5f705"),
    "name": "a",
    "auditType": "fr",
    "collaborators": [],
    "reviewers": [],
    "language": "fr",
    "template": ObjectId("64220c37778ed0b87cb5f6ed"),
    "creator": ObjectId("64220c2d778ed0b87cb5f6d7"),
    "sections": [],
    "customFields": [],
    "sortFindings": [],
    "state": "EDIT",
    "approvals": [],
    "scope": [
        {
            "name": "aa",
            "hosts": []
        },
        {
            "name": "bbb",
            "hosts": []
        }
    ],
    "findings": [],
    "createdAt": ISODate("2023-03-27T21:36:07.524Z"),
    "updatedAt": ISODate("2023-03-27T21:36:11.768Z"),
    "__v": 0
}

from pwndoc-ng.

Zeecka avatar Zeecka commented on June 2, 2024

It may be related to mongoose upgrade ( see pwndoc/pwndoc@af75809#diff-eb434d797b3f5637e7269f5bc9be8842a8e8761c93f3f8347326f9418c746b8cL28 ) , Automattic/mongoose#12325

from pwndoc-ng.

burtonc avatar burtonc commented on June 2, 2024

Confirmed the recent commit on pwndoc fixes the scope table issues

pwndoc/pwndoc@ed86a7f

from pwndoc-ng.

diggidong avatar diggidong commented on June 2, 2024

Unfortunately this does not fix it on my side.
I am on the latest pwndoc-ng master branch.
It renders right when exporting,
but the web app still does have issues with it.
If I reopen a report and it shows [object Object], I am also not able to save it, because of the error:
Cast to embedded failed for value "{ name: { hosts: [] } }" (type Object) at path "scope" because of "CastError"

image

from pwndoc-ng.

burtonc avatar burtonc commented on June 2, 2024

i'm using the latest pwndoc-ng and replaced the files updated in the pwndoc commit to evidence that this seems to be working. I'm sure one the commit is pulled into pwndoc-ng things will be sorted.

image

from pwndoc-ng.

Zeecka avatar Zeecka commented on June 2, 2024

Fixed with #135

from pwndoc-ng.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.