Git Product home page Git Product logo

Comments (19)

nbellocam avatar nbellocam commented on June 24, 2024

Thanks for reporting this. Hacker News link: https://news.ycombinator.com/item?id=9487941

from pwabuilder-cli.

nsbingham avatar nsbingham commented on June 24, 2024

@johnshew if you don't mind me asking, what URL were you using when it failed?

from pwabuilder-cli.

johnshew avatar johnshew commented on June 24, 2024

I don't know what the person on Hacker News was seeing.

Here is the quick test I tried. Just went to http://www.manifoldjs.com/generator.

Entered bing.com as the web site. Hit next. Gave it the name Bing. And hit generate package. Spins. Nothing happens.

It indicates "building package" but then nothing - no package, no error message.

from pwabuilder-cli.

iCityWork avatar iCityWork commented on June 24, 2024

I am not able to use it either, I go to http://www.manifoldjs.com/generator and enter all the info required, I get 0 errors and 0 warnings, 1 suggestion
{
mjs_urlAccess
Required value: It is recommended to specify a set of access rules that represent the navigation scope of the application. Platforms affected: all.
}

Hit Generate and it acts like it is going to do something but never spits out the file.

Help?
Gavin

from pwabuilder-cli.

nsbingham avatar nsbingham commented on June 24, 2024

@johnshew Some updates were pushed to the site that have hopefully fixed the issue you were experiencing.

@iCityWork Would you mind sharing what browser you're using and the URL for which you're trying to generate a package?

from pwabuilder-cli.

iCityWork avatar iCityWork commented on June 24, 2024

@nsbingham I am using Chrome Version 42.0.2311.135 m
last tried about 30 min ago.

from pwabuilder-cli.

boyofgreen avatar boyofgreen commented on June 24, 2024

I received a similar issue tonight. I tried with Bing.com 4 times, and it failed for one of them. And when it failed, no error message or anything.

from pwabuilder-cli.

boyofgreen avatar boyofgreen commented on June 24, 2024

I was using ie11 on windows 8.1

from pwabuilder-cli.

johnshew avatar johnshew commented on June 24, 2024

After a couple of experiments it appears that the generate step fails silently if you fail to have mjs_urlAccess defined.

This is significant for a few reasons:

  • We should NOT require mjs_urlAccess - instead if it is needed and missing is should default to initial URL provided.
  • The right hand pane indicates that having mjs_urlAccess is just a suggestion. Per above this should be correct, but if not needs to be listed as an error.
  • Failing silently on generate is bad behavior. Recommend we should have some sort of developer status while the generate step is happening - maybe just show the -l debug output.

from pwabuilder-cli.

johnshew avatar johnshew commented on June 24, 2024

Opps- accidently closed this issue.

from pwabuilder-cli.

alexkrolick avatar alexkrolick commented on June 24, 2024

Should be more explicit about the format for scope. Does it take a list? Regex? I found that using / as the scope loaded a black page on Android, but relative paths are shown on the W3C example. Ultimately it seems that * should be the default value if you want sites to be able to behave as expected.

from pwabuilder-cli.

marcoscaceres avatar marcoscaceres commented on June 24, 2024

"*" is not a valid default: that will just default to "http://example.com/*/" (literally * path).

from pwabuilder-cli.

marcoscaceres avatar marcoscaceres commented on June 24, 2024

(argh, fixed comment above... it ate my ⭐s)

from pwabuilder-cli.

marcoscaceres avatar marcoscaceres commented on June 24, 2024

Filed bug on the spec to add more examples of scope:
w3c/manifest#380

from pwabuilder-cli.

alexkrolick avatar alexkrolick commented on June 24, 2024

Sounds like there may be differing implementations of scope. When I built for Android, I got a page with no CSS or images if I used /, plus no way to navigate off page. I got a page with no images (served over Cloudfront so off-domain) if I used https://domain.com/*. When I set the scope to * it worked as expected.

from pwabuilder-cli.

marcoscaceres avatar marcoscaceres commented on June 24, 2024

@whokilledtheelectricmonk whoa, strange. Is that for a generated package for Android? Can you provide a bit more details?

from pwabuilder-cli.

alexkrolick avatar alexkrolick commented on June 24, 2024

Just checked on the iOS emulator - same result. The only way off-domain resources are loaded is to provide * in the scope field. I observed the behaviour on an actual Android device using $ cordova run android with a device plugged in. Platform: Mac OS 10.10.

Summary:

*: Everthing loads
https://mysite.com: Can navigate to subpages but no cross-site resources load
https://mysite.com/*: Same as above
https://mysite.com/: Can't navigate off-page, no css or images load
/: blank page

from pwabuilder-cli.

 avatar commented on June 24, 2024

I created a new issue for the discussion about how manifoldjs processes the scope variable

from pwabuilder-cli.

ryanbillingsley avatar ryanbillingsley commented on June 24, 2024

The generator should now let you know if the build failed and provide any error information it has.

from pwabuilder-cli.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.