Git Product home page Git Product logo

Comments (15)

boyofgreen avatar boyofgreen commented on June 24, 2024

Hi Dave, we will review. Seems like a bug. Can you do me a favor? Can you rerun with the -l debug and shoot over the console?

from pwabuilder-cli.

kevincobain2000 avatar kevincobain2000 commented on June 24, 2024

@DaveVoyles
It is because of the new line \r on mac/unix machines. Do the following and it should be fine.

05/03/15 @ 4:15PM - kevincobain2000@Mac Air ~/Downloads cat /usr/local/bin/manifoldjs |col -b > temp;cp temp /usr/local/bin/manifoldjs

Note: I assume your manifoldjs is saved there --> /usr/local/bin/manifoldjs other just do type manifoldjs.


I think the problem is here ..? if you open https://github.com/manifoldjs/ManifoldJS/blob/master/manifoldjs.js#L1 in vim and check out the trailing new line char.

from pwabuilder-cli.

DaveVoyles avatar DaveVoyles commented on June 24, 2024

Kevin,

What does that command do? Which part of the commad should I be coppying?

from pwabuilder-cli.

kevincobain2000 avatar kevincobain2000 commented on June 24, 2024

@DaveVoyles Explained in #36

from pwabuilder-cli.

DaveVoyles avatar DaveVoyles commented on June 24, 2024

I see now, thanks.

So once that pull request is accepted, I can run npm -g install manifoldjs, and terminal will be able to locate the manifoldjs folder.

I'll hold tight until it is accepted

from pwabuilder-cli.

nbellocam avatar nbellocam commented on June 24, 2024

Are you seeing this issue when installing from github directly? (you can use npm install -g manifoldjs/manifoldjs). Note: you may need to clean your npm cache.

from pwabuilder-cli.

DaveVoyles avatar DaveVoyles commented on June 24, 2024

That was the answer!

If you install with just:
npm install -g manifoldjs it does not install correctly.
I needed manifoldjs/manifoldjs

From there, I ran ManifoldJS http://www.DaveVoyles.com and it generated a package.

All went well, but it could be confusing to users when it reads:

WARNING: One or more tasks failed while generating the Cordova application
WARNING: One or more errors occured when generating the application

I know that this is becuase I'm on OSX and doing a build, therefore Windows will not be added to the platform. This is also likely a warning from Cordova, so there's not much you can do there.

Thanks for the tip! Works fine

from pwabuilder-cli.

nickdesaulniers avatar nickdesaulniers commented on June 24, 2024

If you install with just:
npm install -g manifoldjs it does not install correctly.
I needed manifoldjs/manifoldjs

Then the readme should be updated to reflect that. Let's reopen this issue to track that.

from pwabuilder-cli.

nbellocam avatar nbellocam commented on June 24, 2024

Actually, this will be fixed with the new release (v0.1.3). Installing the module from GitHub is just a temporary workaround, as well as for testing purposes. No need to reopen this issue

from pwabuilder-cli.

trevordunn avatar trevordunn commented on June 24, 2024

I just tried installing from the command line and got this error as well (v0.4.1).
Installing with npm install -g manifoldjs/manifoldjs fixed it.

from pwabuilder-cli.

boyofgreen avatar boyofgreen commented on June 24, 2024

Will take a look. Thanks

from pwabuilder-cli.

boyofgreen avatar boyofgreen commented on June 24, 2024

Hi Trevor, I'm not able to re-create this on my pc. Are you using a mac by chance? can you tell me you os version and the NPM version you have installed?

from pwabuilder-cli.

boyofgreen avatar boyofgreen commented on June 24, 2024

Hi Trevor, I am able to see this on my mac as well, I think it's a line ending issue. Working on it

from pwabuilder-cli.

trevordunn avatar trevordunn commented on June 24, 2024

OSX 10.10.5
NPM 2.12.0

from pwabuilder-cli.

 avatar commented on June 24, 2024

Yes, it seems to be related to the line endings: the manifoldjs.js file within the published npm package has CR+LF as line endings instead of just LF.

Even though the manifoldjs.js file has the correct line endings in the repository (just LF), there is a setting that defines how Git handles line endings –my guess it that the Git settings in the machine where the 0.4.1 package was generated is telling Git to convert line endings to CR+LF on checkout.

I generated a pull request to include a .gitattributes that ensures to always use the correct line endings for the manifoldjs.js file, regardless of the Git settings configured in the local machine. In order to fix this issue, I suggest to:

  1. Merge the pull request
  2. Clone the repo again
  3. Make sure that the manifoldjs.js file has the correct line endings (just LF)
  4. Publish a new version

from pwabuilder-cli.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.