Git Product home page Git Product logo

Comments (6)

boyofgreen avatar boyofgreen commented on July 17, 2024

Sure, what is the expected behavior if your offline, would you want them to get an error or are you having other content you pointing to?

from manifoldcordova.

gabn88 avatar gabn88 commented on July 17, 2024

The default cordova behaviour is to keep the page the same, and only show an error after a link is clicked (then it finds out that the internet connection is lost and then it ends/kills the application with this error).

I would like to keep the page the same (so no offline page or whatsever, maybe a small

<div>Offline</div> 

on the page) and when a user clicks a link that it shows an alert('No connection!') and stays on the same page. This is ideal. But the cordova default is already better for my application then the offline page.

from manifoldcordova.

gabn88 avatar gabn88 commented on July 17, 2024

I don't want to push, but do you think this would be possible? I have no experience with writing java , but it doesn't seem to hard (I'm looking at the Android code, as I'm only targetting Android anyway).

Just the option to disable it would be enough for me.

from manifoldcordova.

boyofgreen avatar boyofgreen commented on July 17, 2024

Hi @gabn88 let me talk to the guys who focus on android, we should be able to make an easy way to go back

from manifoldcordova.

mattwoberts avatar mattwoberts commented on July 17, 2024

+1 for this.

I'm having problems getting the offline page to work in ios (#59)

However, using cordova-network-information via the javascript api DOES work fine.. So I can use that to handle the device going off/on-line. BUT - I need to disable the manifold offline page in entirety to get this to work.

Thanks

Matt

from manifoldcordova.

vjrantal avatar vjrantal commented on July 17, 2024

I also had a case where I wanted to disable the offline feature and also get rid of the extra WebViews that are created for it. I created #68 as a draft about an option how it could be made optional.

@boyofgreen: I have a feeling that it is somewhat a "no-brainer" to allow optionally getting rid of the offline feature, but probably the biggest discussion point is should it be opt-in or opt-out. In my initial PR above, I changed the feature opt-in, because I feel that it is a ManifoldJS-specific thing that might come as a "surprise" for a regular Web developer unless explicitly turned on.

I am happy to amend my commit based on the discussion and feedback, but just wanted to throw it out there to get a feeling what others think about this.

from manifoldcordova.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.