Git Product home page Git Product logo

Comments (10)

GrahamCampbell avatar GrahamCampbell commented on May 29, 2024

What php version?

from pusher-http-php.

GrahamCampbell avatar GrahamCampbell commented on May 29, 2024

Having the cacert.pem file in the code base is a bad practice btw.

from pusher-http-php.

zimbatm avatar zimbatm commented on May 29, 2024
$ php -v
PHP 5.5.30 (cli) (built: Oct 23 2015 17:21:45)
Copyright (c) 1997-2015 The PHP Group
Zend Engine v2.5.0, Copyright (c) 1998-2015 Zend Technologies

What is the best practice in regards to cacert.pem ? I know that PHP 5.6 is able to find the system CA certs but what to do with older versions ? I've been looking at Guzzle quite a lot and here is what they do: https://github.com/guzzle/guzzle/blob/master/src/Handler/StreamHandler.php#L352-L353

from pusher-http-php.

zimbatm avatar zimbatm commented on May 29, 2024

Btw if you have any ideas on how to improve the new-lib I'm all ears, I don't qualify as a PHP veteran at all.

from pusher-http-php.

GrahamCampbell avatar GrahamCampbell commented on May 29, 2024

TBH, I'd actually recommend just using guzzle 5/6 and dropping php 5.3 support, but keeping php 5.4 support. Then you don't need to worry about any of this http stuff. Guzzle will do it all for us.

from pusher-http-php.

GrahamCampbell avatar GrahamCampbell commented on May 29, 2024

NB, requiring guzzle ^5.0|^6.0 will allow either version to be resolved for maximum compatibility.

from pusher-http-php.

GrahamCampbell avatar GrahamCampbell commented on May 29, 2024

Also note that guzzle 3 can be installed along side guzzle 4+ because it's technically a different package in a different namesace, so conflicts with older libraries shouldn't be a problem either.

from pusher-http-php.

zimbatm avatar zimbatm commented on May 29, 2024

It's tempting to use guzzle but it also introduces a lot of unnecessary complexity. My hope was to keep this library small and not add too much dependencies.

from pusher-http-php.

GrahamCampbell avatar GrahamCampbell commented on May 29, 2024

Guzzle is small imo, and definitely makes this library smaller and simpler.

from pusher-http-php.

kn100 avatar kn100 commented on May 29, 2024

Closed in preference to #95

from pusher-http-php.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.