Git Product home page Git Product logo

Comments (10)

purpleidea avatar purpleidea commented on July 17, 2024

Patches definitely welcome.

As for RAM/CPU's, @goern started this patch in: #84 but then gave up. Please feel free to write it from scratch or fix his. It should be straightforward.

As for additional HDD's, I actually wrote this feature in vagrant-libvirt, so I'm happy to get it in OMV :) You can look at this: https://github.com/purpleidea/puppet-gluster/blob/master/vagrant/Vagrantfile#L483 for how to add disks, assuming the interface hasn't changed.

HTH,
James

from oh-my-vagrant.

purpleidea avatar purpleidea commented on July 17, 2024

PS: technically OMV works with virtualbox now too. So bonus points if your patch adds the virtualbox hooks, although I won't nack the patch if you don't have them.

from oh-my-vagrant.

br0ziliy avatar br0ziliy commented on July 17, 2024

TBH I did not use VirtualBox for like 7 years now and have no idea how stuff works there this days. Though this does not look like a bad idea to make RAM/CPU/HDD adjustments unified, I will poke around in that direction.

Patch in #84 looks reasonable (well, goern@f2186d5 at least), so I'll use it as a basis for my work, thanks James for pointing that out.

from oh-my-vagrant.

purpleidea avatar purpleidea commented on July 17, 2024

On Fri, May 29, 2015 at 12:27 PM, br0ziliy [email protected] wrote:

TBH I did not use VirtualBox for like 7 years now and have no idea how
stuff works there this days. Though this does not look like a bad idea to
make RAM/CPU/HDD adjustments unified, I will poke around in that direction.

I don't use virtualbox either. Libvirt works so much better! Feel free to
ignore those additions. We'll open an issue for that feature and have a
virtualbox user add that in later.

from oh-my-vagrant.

purpleidea avatar purpleidea commented on July 17, 2024

@br0ziliy ping, still planning on doing this?

Cheers!

from oh-my-vagrant.

br0ziliy avatar br0ziliy commented on July 17, 2024

Hey James,

Yes, sure - was just a bit busy during RH Summit times. I'm definitively on
it though - it's just the time that is the matter.

On Thu, Jul 2, 2015 at 12:54 PM, James [email protected] wrote:

@br0ziliy https://github.com/br0ziliy ping, still planning on doing
this?

Cheers!


Reply to this email directly or view it on GitHub
#92 (comment)
.

Vasiliy Kaygorodov
System Administrator

from oh-my-vagrant.

purpleidea avatar purpleidea commented on July 17, 2024

@br0ziliy @goern

Just added: 92dd418

This should meet everything but the disk configuration aspect. I'll close this ticket for now, until someone actually wants to submit a patch for the disk part.

Please test and confirm this works! I've also tagged this release as 0.0.16 and a COPR build exists too:
https://copr.fedoraproject.org/coprs/purpleidea/oh-my-vagrant/

Cheers!

from oh-my-vagrant.

purpleidea avatar purpleidea commented on July 17, 2024

cc @aweiteka @scollier
Please test... ^^^^

@flavio-fernandes
Can you confirm this works on virtualbox.

Thanks!

from oh-my-vagrant.

br0ziliy avatar br0ziliy commented on July 17, 2024

@purpleidea Thanks for implementing this - works like a charm (tested with vagrant-libvirt)

from oh-my-vagrant.

purpleidea avatar purpleidea commented on July 17, 2024

@br0ziliy YW! enjoy

from oh-my-vagrant.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.