Comments (6)
...but that would seem to be a more general problem for movie titles containing other characters...
Yes, searching by the title is always wonky. Best is if a site supports searching by IMDb ID.
I guess this means your Netflix entry does need a spaceEncode key just like for Netflix-DVD, or maybe '%20'?
Test what works, I can't.
I'm afraid I don't know how to submit a PR.
It's simple, look there -> #209
from imdb-scout-mod.
The instructions in #209 didn't match exactly with the steps I had to follow
Then you can post there an alternative instruction seen by you.
Btw, I checked before writing what buttons to press, maybe stuff is different for you for some reason.
I've managed it with PR #210.
Merged!
from imdb-scout-mod.
...but %2B is always incorrect...
Write that to the Netflix.
...then it's best to just not use the '+' character for space encoding and just stick to percent-encoding for everything...
We don't have control of how the sites encode urls, here we don't encode urls.
Here by default we replace spaces with '+' as that's what most sites accepts, you can change default behavior with spaceEncode
.
I think there is a bug pertaining to how search strings are being escaped. For example, with the Netflix icon site
Not a bug in general, it's a bug with Netflix entry.
The sites can change their code and a site entry may stop working after some time.
So, submit PR with a correcting update. [look at "Netflix-DVD" entry]
from imdb-scout-mod.
My apologies for not cluing in that no escaping was being done. Maybe I'm still missing something, but that would seem to be a more general problem for movie titles containing other characters that are not legal or have special meaning in URLs (eg. '%', '#', accented characters, non-ASCII, etc), for all sites, not just Netflix.
Anyway, for Netflix its own search functionality generates URLs using %20 for spaces. Example:
https://www.netflix.com/search?q=The%20Marsh%20King%27s%20Daughter
I guess this means your Netflix entry does need a spaceEncode key just like for Netflix-DVD, or maybe '%20'? I'm afraid I don't know how to submit a PR.
from imdb-scout-mod.
The instructions in #209 didn't match exactly with the steps I had to follow, but I'm hopeful I've managed it with PR #210.
from imdb-scout-mod.
Thank you :-)
I'm using a somewhat unusual browser configuration, so that likely explains why I'm seeing steps a little different than you.
from imdb-scout-mod.
Related Issues (20)
- feature request: open result from https://filmfans.org/ HOT 1
- feature request: magnetdl.com HOT 1
- OnlyEncodes HOT 3
- does therarbg.com work? HOT 1
- ofdb.de seems not work HOT 1
- Filmweb HOT 1
- How can I get the old IMDb layout? HOT 1
- Psarips New Domain HOT 2
- Enable the 3rd search bar didn't work HOT 9
- Where can I find Custom Quality Profileid? HOT 1
- "titrari.ro" change the search page. Again. HOT 11
- Jellyfin skips on chinese HOT 7
- Request: Country alternatives for JustWatch HOT 4
- support for http://nanyangpt.com HOT 5
- Request: Search icon for libraries using Bibliocommons HOT 3
- Guide how to add new sites or submit edits to the script
- Flickmetrix doesn't work for some titles HOT 1
- Adding more services HOT 2
- Add Simkl.com as external rating site? HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from imdb-scout-mod.