Git Product home page Git Product logo

Comments (9)

chrroberts-pure avatar chrroberts-pure commented on August 17, 2024

Hi Lukas,

I agree this is a good request.

This information is available in the Purity API in GET /ports. That URI has not been implemented in the OpenMetrics exporter.

@LukasBr1337 do you have any suggests on Semantic Conventions for this new suggested info metric? (eg for purefa-metrics.md ) or any suggestion what this metric output should look like?

from pure-fa-openmetrics-exporter.

LukasBr1337 avatar LukasBr1337 commented on August 17, 2024

for other vendors we know it like that -> /23:43:00:02:ac:02:5c:07/3:4:3/iops" 3:4:3 would be in this case Node:Slot:port

from pure-fa-openmetrics-exporter.

chrroberts-pure avatar chrroberts-pure commented on August 17, 2024

Here's a POC that I've built in my environment

I went ahead and wrote it for all port types. NVMe, iSCSI, and FC. My testing results are below.

Would this fit your requirements @LukasBr1337 ?

# HELP purefa_ports_fc_info FlashArray ports fc info
# TYPE purefa_ports_fc_info gauge
purefa_ports_fc_info{name="CT0.FC0",wwn="XX:XX:XX:XX:XX:XX:XX:00"} 1
purefa_ports_fc_info{name="CT0.FC1",wwn="XX:XX:XX:XX:XX:XX:XX:01"} 1
purefa_ports_fc_info{name="CT0.FC2",wwn="XX:XX:XX:XX:XX:XX:XX:02"} 1
purefa_ports_fc_info{name="CT0.FC3",wwn="XX:XX:XX:XX:XX:XX:XX:03"} 1
purefa_ports_fc_info{name="CT0.FC8",wwn="XX:XX:XX:XX:XX:XX:XX:08"} 1
purefa_ports_fc_info{name="CT0.FC9",wwn="XX:XX:XX:XX:XX:XX:XX:09"} 1
purefa_ports_fc_info{name="CT1.FC0",wwn="XX:XX:XX:XX:XX:XX:XX:10"} 1
purefa_ports_fc_info{name="CT1.FC1",wwn="XX:XX:XX:XX:XX:XX:XX:11"} 1
purefa_ports_fc_info{name="CT1.FC2",wwn="XX:XX:XX:XX:XX:XX:XX:12"} 1
purefa_ports_fc_info{name="CT1.FC3",wwn="XX:XX:XX:XX:XX:XX:XX:13"} 1
purefa_ports_fc_info{name="CT1.FC8",wwn="XX:XX:XX:XX:XX:XX:XX:18"} 1
purefa_ports_fc_info{name="CT1.FC9",wwn="XX:XX:XX:XX:XX:XX:XX:19"} 1
# HELP purefa_ports_iscsi_info FlashArray port iscsi info
# TYPE purefa_ports_iscsi_info gauge
purefa_ports_iscsi_info{iqn="iqn.2010-06.com.purestorage:flasharray.xxxxxxxxxxxxxxxx",name="CT0.ETH4",portal="192.168.x.1:3260"} 1
purefa_ports_iscsi_info{iqn="iqn.2010-06.com.purestorage:flasharray.xxxxxxxxxxxxxxxx",name="CT0.ETH5",portal="192.168.x.2:3260"} 1
purefa_ports_iscsi_info{iqn="iqn.2010-06.com.purestorage:flasharray.xxxxxxxxxxxxxxxx",name="CT1.ETH4",portal="192.168.x.3:3260"} 1
purefa_ports_iscsi_info{iqn="iqn.2010-06.com.purestorage:flasharray.xxxxxxxxxxxxxxxx",name="CT1.ETH5",portal="192.168.x.4:3260"} 1
# HELP purefa_ports_nvmeof_info FlashArray ports nvmeof info
# TYPE purefa_ports_nvmeof_info gauge
purefa_ports_nvmeof_info{name="CT0.ETH14",nqn="nqn.2010-06.com.purestorage:flasharray.xxxxxxxxxxxxxxxx",portal="192.168.x.5:4420"} 1
purefa_ports_nvmeof_info{name="CT0.ETH15",nqn="nqn.2010-06.com.purestorage:flasharray.xxxxxxxxxxxxxxxx",portal="192.168.x.6:4420"} 1
purefa_ports_nvmeof_info{name="CT1.ETH14",nqn="nqn.2010-06.com.purestorage:flasharray.xxxxxxxxxxxxxxxx",portal="192.168.x.7:4420"} 1
purefa_ports_nvmeof_info{name="CT1.ETH15",nqn="nqn.2010-06.com.purestorage:flasharray.xxxxxxxxxxxxxxxx",portal="192.168.x.8:4420"} 1

Note, none of the names, descriptions..etc are finalized - just demonstrating for now.

from pure-fa-openmetrics-exporter.

LukasBr1337 avatar LukasBr1337 commented on August 17, 2024

looks pretty good for us :)

BR

Lukas

from pure-fa-openmetrics-exporter.

LukasBr1337 avatar LukasBr1337 commented on August 17, 2024

only request... lower cases would be great :D

from pure-fa-openmetrics-exporter.

sdodsley avatar sdodsley commented on August 17, 2024

@LukasBr1337 FlashArrays produce their WWNs in uppercase and we are just directly reporting what the array sends us. Is there a specific reason why you would prefer them lowercase?

from pure-fa-openmetrics-exporter.

sdodsley avatar sdodsley commented on August 17, 2024

Alos, we currently report the hosts WWN information in uppercase as well, so moving to lowercase would create a misnatch of cases across different responses.

from pure-fa-openmetrics-exporter.

LukasBr1337 avatar LukasBr1337 commented on August 17, 2024

From other vendors and from the brocade switches we are getting them in lowercase so it would match better like that

from pure-fa-openmetrics-exporter.

chrroberts-pure avatar chrroberts-pure commented on August 17, 2024

@LukasBr1337 It is common for observability platforms to convert all tags to lowercase - such as this example in Datadog. This would convert the tags to lowercase like you are requesting

https://docs.datadoghq.com/getting_started/tagging/#define-tags

This example is with Datadog

Screenshot 2024-02-13 at 2 05 02 PM

from pure-fa-openmetrics-exporter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.