Git Product home page Git Product logo

Comments (6)

reidmv avatar reidmv commented on June 30, 2024

This is probably resolved by #75

from puppetlabs-peadm.

vchepkov avatar vchepkov commented on June 30, 2024

Ideally it would fail a bit earlier, but it does fail, so I think we can close this

Starting: plan peadm::upgrade
Starting: task peadm::trusted_facts on puppet.chepkov.lan
Finished: task peadm::trusted_facts with 0 failures in 3.59 sec
Starting: task peadm::precheck on puppet.chepkov.lan
Finished: task peadm::precheck with 0 failures in 1.28 sec
Starting: plan peadm::util::retrieve_and_upload
Starting: task peadm::download on local://localhost
Finished: task peadm::download with 0 failures in 0.43 sec
Starting: task peadm::filesize on local://localhost
Finished: task peadm::filesize with 0 failures in 0.11 sec
Starting: task peadm::filesize on puppet.chepkov.lan
Finished: task peadm::filesize with 0 failures in 1.62 sec
Starting: file upload from /opt/staging/puppet-enterprise-2020.1.0-el-8-x86_64.tar.gz to /tmp/puppet-enterprise-2020.1.0-el-8-x86_64.tar.gz on puppet.chepkov.lan
Finished: file upload from /opt/staging/puppet-enterprise-2020.1.0-el-8-x86_64.tar.gz to /tmp/puppet-enterprise-2020.1.0-el-8-x86_64.tar.gz with 0 failures in 1.24 sec
Finished: plan peadm::util::retrieve_and_upload in 3.43 sec
Starting: task service on puppet.chepkov.lan
Finished: task service with 0 failures in 2.61 sec
Starting: task peadm::pe_install on puppet.chepkov.lan
Finished: task peadm::pe_install with 1 failure in 1.36 sec
Finished: plan peadm::upgrade in 12.34 sec
Finished: plan maint::upgrade in 16.32 sec
Failed on puppet.chepkov.lan:
  The task failed with exit code 127:
  tar: This does not look like a tar archive
  
  gzip: stdin: not in gzip format
  tar: Child returned status 1
  tar: Error is not recoverable: exiting now
  dirname: missing operand
  Try 'dirname --help' for more information.
  
  gzip: stdin: not in gzip format
  tar: Child returned status 1
  tar: Error is not recoverable: exiting now
  /bin/bash: /tmp//puppet-enterprise-installer: No such file or directory
Failed on 1 target: puppet.chepkov.lan
Ran on 1 target

from puppetlabs-peadm.

reidmv avatar reidmv commented on June 30, 2024

It might be sufficient to just set -e at the top of the bash script. I haven't tested or considered if there are any intermediate commands that are expected to return non-zero exit codes in normal circumstances. If we were able to use set -e, it would fail immediately as soon as any command failed.

from puppetlabs-peadm.

vchepkov avatar vchepkov commented on June 30, 2024

yep, that could be the proper solution.

Unfortunately, cloudfront returns 200 even when you download a garbage instead of archive, not much can be done here

from puppetlabs-peadm.

reidmv avatar reidmv commented on June 30, 2024

This experience should now be further improved by error handling added to peadm::download in #92.

from puppetlabs-peadm.

davidsandilands avatar davidsandilands commented on June 30, 2024

Fixed by #152

from puppetlabs-peadm.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.