Comments (16)
kbarber
commented on June 24, 2024
I can't replicate this, tested:
- Debian 7.0, Ruby 1.9.3, Puppet 3.0.0, 3.0.1, 3.1.0.
- Centos 6.3, Ruby 1.8.7, Puppet 3.0.0, 3.0.1, 3.1.0.
from puppetlabs-firewall.
ruckc
commented on June 24, 2024
I had an issue when moved to 3.0, the pull request #98 fixed it.
from puppetlabs-firewall.
kbarber
commented on June 24, 2024
@ruckc well, I can't replicate it even on 3.0.2 (centos 6):
puppet --version
3.0.2
puppet apply /tmp/foo.pp
Notice: /Firewall[050 foo]/ensure: created
Notice: Finished catalog run in 0.12 seconds
puppet module list
/etc/puppet/modules
├── puppetlabs-apt (v1.1.0)
├── puppetlabs-firewall (v0.1.0)
├── puppetlabs-postgresql (v2.1.0)
├── puppetlabs-stdlib (v3.2.0)
└── ripienaar-concat (v0.2.0)
from puppetlabs-firewall.
phemmer
commented on June 24, 2024
I am running puppet 3.1.0 and am still encountering this issue.
I'm not sure what you're trying to duplicate the issue, but I get it when I change the port number of an existing firewall rule.
from puppetlabs-firewall.
kbarber
commented on June 24, 2024
@phemmer what issue exactly? Like I said - if its the method_missing one I can't replicate it on a clean system - there must be something environmental that is special to cause this to happen.
from puppetlabs-firewall.
phemmer
commented on June 24, 2024
Error: /Firewall[100 nginx]/dport: change from 80 to 80,443 failed: The iptables provider can not handle attribute dport
EDIT: The pull request (#98) mentioned by rucks does fix the issue.
from puppetlabs-firewall.
kbarber
commented on June 24, 2024
Aah so its on change, okay ... I can work with that @phemmer thanks for the info, however #98 is too static - we need a better fix. Let me fix it.
from puppetlabs-firewall.
ruckc
commented on June 24, 2024
#98 worked for me without issue.
Curtis Ruck
Anytime: 210-857-1126
On Thu, Feb 28, 2013 at 4:04 PM, Ken Barber [email protected]:
Aah so its on change, okay ... I can work with that @phemmerhttps://github.com/phemmerthanks for the info, however
#98 #98 is too
static - we need a better fix. Let me fix it.—
Reply to this email directly or view it on GitHubhttps://github.com//issues/128#issuecomment-14257498
.
from puppetlabs-firewall.
kbarber
commented on June 24, 2024
@ruckc except when you hit a parameter that someone forgot to add to that static list I bet. You just haven't hit that particular case.
Anyway, I've merged in a fix that uses the resource_map.
from puppetlabs-firewall.
phemmer
commented on June 24, 2024
Now I'm getting this:
Error: /Firewall[100 nginx]/dport: change from 80 to 80,443 failed: wrong number of arguments (1 for 0)
I'm qubit on irc if that makes this easier.
from puppetlabs-firewall.
kbarber
commented on June 24, 2024
Can you run it with a --trace?
from puppetlabs-firewall.
phemmer
commented on June 24, 2024
Error: wrong number of arguments (1 for 0)
/var/lib/puppet/lib/puppet/provider/firewall/iptables.rb:76:in `block (3 levels) in <top (required)>'
/usr/lib/ruby/vendor_ruby/puppet/property.rb:174:in `call_provider'
/usr/lib/ruby/vendor_ruby/puppet/property.rb:494:in `set'
/usr/lib/ruby/vendor_ruby/puppet/property.rb:572:in `sync'
/usr/lib/ruby/vendor_ruby/puppet/transaction/resource_harness.rb:114:in `apply_parameter'
/usr/lib/ruby/vendor_ruby/puppet/transaction/resource_harness.rb:62:in `block in perform_changes'
/usr/lib/ruby/vendor_ruby/puppet/transaction/resource_harness.rb:60:in `each'
/usr/lib/ruby/vendor_ruby/puppet/transaction/resource_harness.rb:60:in `perform_changes'
/usr/lib/ruby/vendor_ruby/puppet/transaction/resource_harness.rb:133:in `evaluate'
/usr/lib/ruby/vendor_ruby/puppet/transaction.rb:48:in `apply'
/usr/lib/ruby/vendor_ruby/puppet/transaction.rb:83:in `eval_resource'
/usr/lib/ruby/vendor_ruby/puppet/transaction.rb:103:in `block (2 levels) in evaluate'
/usr/lib/ruby/vendor_ruby/puppet/util.rb:351:in `block in thinmark'
/usr/lib/ruby/1.9.1/benchmark.rb:295:in `realtime'
/usr/lib/ruby/vendor_ruby/puppet/util.rb:350:in `thinmark'
/usr/lib/ruby/vendor_ruby/puppet/transaction.rb:103:in `block in evaluate'
/usr/lib/ruby/vendor_ruby/puppet/transaction.rb:382:in `traverse'
/usr/lib/ruby/vendor_ruby/puppet/transaction.rb:98:in `evaluate'
/usr/lib/ruby/vendor_ruby/puppet/resource/catalog.rb:144:in `apply'
/usr/lib/ruby/vendor_ruby/puppet/configurer.rb:122:in `block in apply_catalog'
/usr/lib/ruby/vendor_ruby/puppet/util.rb:179:in `block in benchmark'
/usr/lib/ruby/1.9.1/benchmark.rb:295:in `realtime'
/usr/lib/ruby/vendor_ruby/puppet/util.rb:178:in `benchmark'
/usr/lib/ruby/vendor_ruby/puppet/configurer.rb:121:in `apply_catalog'
/usr/lib/ruby/vendor_ruby/puppet/configurer.rb:179:in `run'
/usr/lib/ruby/vendor_ruby/puppet/agent.rb:45:in `block (5 levels) in run'
/usr/lib/ruby/vendor_ruby/puppet/agent/locker.rb:20:in `lock'
/usr/lib/ruby/vendor_ruby/puppet/agent.rb:45:in `block (4 levels) in run'
/usr/lib/ruby/1.9.1/sync.rb:227:in `sync_synchronize'
/usr/lib/ruby/vendor_ruby/puppet/agent.rb:45:in `block (3 levels) in run'
/usr/lib/ruby/vendor_ruby/puppet/agent.rb:119:in `with_client'
/usr/lib/ruby/vendor_ruby/puppet/agent.rb:42:in `block (2 levels) in run'
/usr/lib/ruby/vendor_ruby/puppet/agent.rb:84:in `run_in_fork'
/usr/lib/ruby/vendor_ruby/puppet/agent.rb:41:in `block in run'
/usr/lib/ruby/vendor_ruby/puppet/application.rb:179:in `call'
/usr/lib/ruby/vendor_ruby/puppet/application.rb:179:in `controlled_run'
/usr/lib/ruby/vendor_ruby/puppet/agent.rb:39:in `run'
/usr/lib/ruby/vendor_ruby/puppet/application/agent.rb:338:in `onetime'
/usr/lib/ruby/vendor_ruby/puppet/application/agent.rb:312:in `run_command'
/usr/lib/ruby/vendor_ruby/puppet/application.rb:364:in `block (2 levels) in run'
/usr/lib/ruby/vendor_ruby/puppet/application.rb:456:in `plugin_hook'
/usr/lib/ruby/vendor_ruby/puppet/application.rb:364:in `block in run'
/usr/lib/ruby/vendor_ruby/puppet/util.rb:504:in `exit_on_fail'
/usr/lib/ruby/vendor_ruby/puppet/application.rb:364:in `run'
/usr/lib/ruby/vendor_ruby/puppet/util/command_line.rb:132:in `run'
/usr/lib/ruby/vendor_ruby/puppet/util/command_line.rb:86:in `execute'
/usr/bin/puppet:4:in `<main>'
Error: /Firewall[100 nginx]/dport: change from 80 to 80,443 failed: wrong number of arguments (1 for 0)
from puppetlabs-firewall.
kbarber
commented on June 24, 2024
@ruckc try again on master - looks like it was a Ruby 1.9 v 1.8 syntax mistake on my part.
from puppetlabs-firewall.
phemmer
commented on June 24, 2024
@kbarber I'm assuming you meant to me :-)
Did you push that to github? I'm not seeing anything on puppetlabs/puppetlabs-firewall
from puppetlabs-firewall.
kbarber
commented on June 24, 2024
@phemmer yeah I'm just not with it today. Okay I've pushed it.
from puppetlabs-firewall.
phemmer
commented on June 24, 2024
Yup, all good now. Thanks :-)
from puppetlabs-firewall.
Related Issues (20)
- Use nftables instead of iptables where it is supported.
- Getting problems on the firewall on redhat 8
- No value is detected for nflog-prefix HOT 2
- Allow --reject-with tcp-reset for TCP rules
- Could not evaluate: `proto` must be set to `tcp` for `isfragment` to be true.
- firewall.toports expects an undef value or a match for Pattern[/^\d+(?:-\d+)?$/], got Integer
- Hyphen in the ipset's hash name breaks a firewall resource
- Puppet repeatedly attempts to correct firewall rules when `source` has a prefix length of zero HOT 8
- Add path option for cgroup
- Add back IPv6 protocol support for recent rule masks HOT 1
- Add support for parsing and using socket parameters
- issue with match_mark regex HOT 1
- Performance degradation in resource_api version
- single quotes in rule comments produces errors HOT 4
- puppet generate types fail on versions >= 7.0.0 HOT 2
- Non idempotent logs for empty firewall chains HOT 8
- hostnames with multiple address are not handled completely
- Link in CONTRIBUTING.md returns a 404.
- Defining a state as an array can cause an unnecessary updating action
- Using a LOG jump with a log_level of 4 causes an unnecessary updating action
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from puppetlabs-firewall.