Improve docs about beaker-puppet_install_helper HOT 3 OPEN

There is no other way to choose the installed package type and version, other than the mentioned environment variables, when using this gem.

The wrong defaults should be fixed, indeed.

from beaker-puppet_install_helper.

Based on @dhoppe's comment, it seems like

CONFIG:
  type: agent

should work after all? https://github.com/puppetlabs/beaker-puppet_install_helper/blob/master/lib/beaker/puppet_install_helper.rb#L77-L86

from beaker-puppet_install_helper.

I think the use of Beaker should be as simple as possible. This means the Contributor should not have to perform more than the following commands: bundle exec rake beaker:sets and bundle exec rake beaker:ubuntu-server-1604-x64

Unfortunately the parameter type: agent has no effect, which means that run_puppet_install_helper will always use install_puppet_on instead of install_puppet_agent_on to install Puppet.

The problem ist that Puppet does not provide any packages of Puppet 3.x for Ubuntu 16.04.x and this will result in the following error message:

/Users/dhoppe/.rvm/gems/ruby-2.3.1@voxpupuli/gems/beaker-3.3.0/lib/beaker/host.rb:366:in `exec': Host 'ubuntu-server-1604-x64' exited with 8 running: (Beaker::Host::CommandFailure)
 wget -O /tmp/puppet.deb http://apt.puppetlabs.com/puppetlabs-release-xenial.deb
Last 10 lines of output were:
    --2016-11-08 04:31:33--  http://apt.puppetlabs.com/puppetlabs-release-xenial.deb
    Resolving apt.puppetlabs.com (apt.puppetlabs.com)... 198.58.114.168, 2600:3c00::f03c:91ff:fe69:6bf0
    Connecting to apt.puppetlabs.com (apt.puppetlabs.com)|198.58.114.168|:80... connected.
    HTTP request sent, awaiting response... 404 Not Found
    2016-11-08 04:31:33 ERROR 404: Not Found.

Since Puppet 3.x will be EOL at 2016-12-31, I highly recommend to change the default values so that Puppet 4 is being installed.

For Travis CI, we can still provide PUPPET_INSTALL_TYPE and PUPPET_INSTALL_VERSION to test against different versions of Puppet, but the Contributor should not have to do that.

from beaker-puppet_install_helper.