Emulation API proposal about puppeteer HOT 5 CLOSED

@paulirish @pavelfeldman guys, guys. WDYT?

from puppeteer.

Not sure if this makes things any better. Today, device is a pair or {viewport, userAgent}. It seems that the only change that you suggest is merging them into a single device entity and introducing a new emulateDevice method? Although that is fine with me, it makes UA emulation redundant (you already have specific methods for UA emulation). Looks like super-minor sugar overall. Today you can do:

// If needed, a hand-made device could be done
let device = {
  width: 100,
  height: 100,
  deviceScaleFactor: 2
});

page.setViewport(device);
// When I want UA,
page.setUserAgent(deviceUserAgent);

from puppeteer.

It seems that the only change that you suggest is merging them into a single device entity and introducing a new emulateDevice method?

That's right. Here's a summary of the changes:

• make page.emulateDevice(deviceConfig) instead of page.emulate(deviceName) so that there's a single entry point for device emulation
• make page.setOrientation method so that orientation is not a part of a viewport
• expose pre-built devices as structs in the top-level require to make it simple to inspect devices and their emulation configs

Although that is fine with me, it makes UA emulation redundant (you already have specific methods for UA emulation).

It's still nice to have both setUserAgent and setViewport methods - they might come handy at times. However, I think that a lot of times those who use page.setUserAgent or page.setViewport would rather emulate some device.

from puppeteer.

const samsungDevices = requires(./sd);
const devices = require(puppeteer/DeviceDescriptors);

await page.emulateDevice(samsungDevices['GSIII_landscape']);
  await page.setViewport(device.viewport);
  await page.setUserAgent(device.ua));

from puppeteer.

With the last patch, everything we've discussed is done. There's no page.emulateDevice for now, instead it's suggested to use setViewport / setUserAgent methods explicitly.

I've updated the doc to explain about emulation: emulation

from puppeteer.