Git Product home page Git Product logo

Comments (3)

JoelEinbinder avatar JoelEinbinder commented on April 28, 2024

I tried using typescript to do type checking. I had some success after removing all of our requires and module exports, and concatenating everything into one big file. There were a lot of errors because our WebSocket is different from browser's WebSocket, and typescript gets confused by frame.evaluate because of the context switch and the way arguments are passed in.

from puppeteer.

sukrosono avatar sukrosono commented on April 28, 2024

Did the code base will use typescript after pull number 219 finished ? 😨

from puppeteer.

aslushnikov avatar aslushnikov commented on April 28, 2024

Did the code base will use typescript after pull number 219 finished ? 😨

@brutalcrozt no, we'll continue using JS with jsdoc annotations.

from puppeteer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.