Git Product home page Git Product logo

Comments (11)

aslushnikov avatar aslushnikov commented on April 28, 2024 19

wait, we still want to have page.setOfflineMode implemented :)

from puppeteer.

Garbee avatar Garbee commented on April 28, 2024 2

If you don't want to run as root but still want to have some level of automated traffic shaping (even if low fidelity). Then what you'd want to do is setup a proxy for those tests. Do it where any tests that need throttling use an instance that is talking to your proxy that will handle the network manipulation. You'd pass the proxy in when launching an instance just like you would from the command line as an arg option.

let instance = puppeteer.launch({
  args: [
   '--proxy-server=127.0.0.1:9876', // Or whatever the address is 
  ]
});

This allows you to use other external tools to manage the network shaping. Such as Charles Proxy on Mac OS. Finding a good cross-platform solution for testing is difficult though, as Windows in particular is dramatically different to talk to.

from puppeteer.

Garbee avatar Garbee commented on April 28, 2024 1

A proxy should. Since that is an entire external man-in-the-middle between the program and the network interface.

from puppeteer.

aslushnikov avatar aslushnikov commented on April 28, 2024

@paulirish @ebidel how do you guys feel about the page.setOfflineMode? This seems to be trivial to implement but really useful. We can add a page.setNetworkConditions(condition) method later if there's a need to, and keep the setOfflineMode as an alias for setNetworkConditions('offline').

from puppeteer.

aslushnikov avatar aslushnikov commented on April 28, 2024

This is blocked on Chrome Headless network emulation support: https://bugs.chromium.org/p/chromium/issues/detail?id=728451

from puppeteer.

aslushnikov avatar aslushnikov commented on April 28, 2024

As discussed with @pavelfeldman, we should not do anything other then setOfflineMode - we're pretty bad at network shaping. There's a specific tooling which does this much better and on a much lower level.

from puppeteer.

benjamingr avatar benjamingr commented on April 28, 2024

@aslushnikov do you mind elaborating on this? I would love to be able to do network emulation to test scenarios in my app.

Alternatively, a docker container image that runs something that does do network condition throttling would be great.

For example I need to test a scenario where 2 clients are communicating with a server.

from puppeteer.

paulirish avatar paulirish commented on April 28, 2024

@benjamingr The devtools throttling has some issues: Network Throttling & Chrome - status

Alternatively, a docker container image that runs something that does do network condition throttling would be great.

I've discussed this with Pat Meenan of webpagetest and he indicates docker isn't a reliable solution for network shaping as you cannot modify the network interface within the container; the network interface is bridged with the host. This was unfortunate news to me as well. :)

Using dummynet to change the entire system's network shaping (and requiring sudo) are just required on the host machine for high quality throttling. Not ideal but that's what it is.

from puppeteer.

benjamingr avatar benjamingr commented on April 28, 2024

Thanks @Garbee that's very helpful.

@paulirish that makes sense. I think we'll go ahead with a proxy server solution.

from puppeteer.

benjamingr avatar benjamingr commented on April 28, 2024

@Garbee would that also intercept DataChannels traffic?

from puppeteer.

benjamingr avatar benjamingr commented on April 28, 2024

Thanks, I think that this can be closed now.

from puppeteer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.