The phantom's approach to handling java dialogs is convenient and familiar: inst

<a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/us

So we've sat with <a class="user-mention notranslate" data-hovercard-type="user" data-

Refactor JavaScript dialogs API about puppeteer HOT 5 CLOSED

aslushnikov commented on April 28, 2024

Refactor JavaScript dialogs API

from puppeteer.

Comments (5)

dgozman commented on April 28, 2024 1

I think onFoo is a nice way to subscribe to events. We use it in our testing harnesses a lot.

page.onAlert(message => {
  console.log(message);
});

from puppeteer.

ebidel commented on April 28, 2024 1

I like it.

from puppeteer.

aslushnikov commented on April 28, 2024

@dgozman: the 'onAlert', 'onPrompt" and 'onConfirm' setters feel foreign to the rest of the API.
For example:

var Browser = require('puppeteer').Browser;
var browser = new Browser();
browser.newPage().then(async page => {
    await page.setViewportSize({width: 1000, height: 1000});
    await page.navigate('http://example.com');
    page.onAlert = message => {
        console.log(message);
    };
    page.onConfirm = message => {
        console.log(message);
        return true;
    }
});

How about having page.setAlertCallback instead?
Will look like this:

var Browser = require('puppeteer').Browser;
var browser = new Browser();
browser.newPage().then(async page => {
    await page.setViewportSize({width: 1000, height: 1000});
    await page.navigate('http://example.com');
    page.setAlertCallback(message => {
        console.log(message);
    });
    page.setConfirmCallback(message => {
        console.log(message);
        return true;
    });
});

I like setAlertCallback - it is simple and consistent with the rest of the api. What do you think?

from puppeteer.

aslushnikov commented on April 28, 2024

So we've sat with @paulirish and get a feeling of a few options here.

We don't like the following, cause it makes it hard to dismiss all the dialogs:

page.on('alert', message => {
   console.log(message);
});

We don't like the phantom's way, 'cause it's weird:

page.onPrompt = message => {
   return {
     text, success
   }
};

We don't like the dialog callback, 'cause it's too verbose:

page.setDialogCallback(dialog => {
   dialog.accept()
   dialog.type()
   dialog.dismiss();
});

The thing which we liked most is the event with dialog class:

page.on('dialog', dialog => {
   dialog.type // 'alert', 'confirm', 'prompt', 'beforeunload'
   dialog.accept(); // takes optional string
   dialog.dismiss();
});

How do you guys feel? @dgozman @ebidel

from puppeteer.

aslushnikov commented on April 28, 2024

For the record: dialog handling is currently suffering on headless due to the crbug.com/718235. This bug results in all the javascript dialogs being dismissed on headless.

from puppeteer.

Recommend Projects