Comments (2)
Sure. I can send a PR with the update.
from puppeteer.
Mind if we switch to 2-space identation?
The 2-space indentation sounds fine for me - would you mind sending a pr?
...we tend to stick with Google's style guide in the GoogleChrome org.
The current eslintrc.js is a copy of chrome devtools eslintrc (with the only difference of 4 spaces, for historic reasons).
I'm not really familiar with the Google's style guide. I think it's fine to adopt it if there's a tool which enforces it to full extend - so that we don't end up with a code written in a mixture of devtool's and google styles.
from puppeteer.
Related Issues (20)
- Document browser.debugInfo in the debugging guide
- TimeOutError HOT 2
- [Bug]: ERR_INSUFFICIENT_RESOURCES HOT 3
- [Bug]: Screen-cast Crashes from Time to Time HOT 2
- [Feature]: Add Worker.close method to allow terminating service workers
- [Bug]: Executable path is not properly generated when using `PUPPETEER_BROWSER_REVISION=stable` HOT 7
- browser.debugInfo test might catch pending calls from a previous test
- [page.spec] Page Page.waitForNetworkIdle should work with aborted requests is flaky HOT 2
- [Feature]: Support listing and/or searching with @puppeteer/browsers HOT 1
- [Bug]: i use puppeteer-core in Chrome extension ,but is has some question: "urlToHttpOptions" is not exported by "__vite-browser-external", imported by "node_modules/@puppeteer/browsers/lib/esm/httpUtil.js". HOT 2
- WebDriver BiDi headless tests should be enabled for new-headless as well
- [Bug]: console events relies on non-specified property HOT 2
- [Bug]: Unsupported Frame Type HOT 4
- [Bug]: Triggering commands of browser extension does not work with webDriverBiDi enabled HOT 4
- B5690EEEBB952194
- [Bug]: When the parent element has a zoom value applied, taking a screenshot using elementHandle.screenshot captures the incorrect area. HOT 3
- [Feature]: `Frame.waitForNavigation` should be frame specific
- [Feature]: Inspect owners for a given worker
- [Feature]: Fix Leaking async ops in Deno HOT 2
- Disregard HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from puppeteer.