What to do with `page.evaluateAsync`? about puppeteer HOT 3 CLOSED

Phantom's evaluateAsync is a totally different beast, (which is not needed in our case since most of puppeteer's api's return promises). This is a good argument towards removing puppeteer's evaluateAsync - to avoid confusion.

Though, do we want to match the Phantom API as much as possible?

I think we want to strike a good balance between having a familiar API while not missing the opportunity to improve. So if there are a few options to implement X and there is no clear winner, we should pick the one which is more familiar for phantom users.

from puppeteer.

Guys, I would appreciate your feedback on this! cc @ebidel @paulirish @dgozman

from puppeteer.

FWIW, from our experience w/ Lighthouse, lots of the code we've needed to eval in the page needs to be wrapped in a promise. Basically, anything non-trivial the user will be doing. Also, most of the web platform APIs have moved towards promises, so devs are used to dealing with them. async/await only make things easier.

I like the idea of one method. Simplify + keep things async. Though, do we want to match the Phantom API as much as possible? It might be easier to transition existing users.

from puppeteer.